Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-9104 Thumbnail lag when moving tabs (backport #20539) #20549

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Bugfix FXIOS-9104 Thumbnail lag when moving tabs (backport #20539) #20549

merged 1 commit into from
Jun 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 4, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Remove collectionView.reloadData() from animation in perform batch updates fixes this bug. Apparently it's best practice to not call this in the animation block. This is a fix for the tab tray refactor.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #20539 done by [Mergify](https://mergify.com).

@dataports @mergify
Bugfix FXIOS-9104 Thumbnail lag when moving tabs (#20539)
bb5f463 
Co-authored-by: Sophie Amin <samin@KPQ47DG99L.lan>
(cherry picked from commit 0449b84)
@mergify mergify bot requested a review from a team as a code owner June 4, 2024 17:51
@mergify mergify bot requested review from mattreaganmozilla and removed request for a team June 4, 2024 17:51
@mergify mergify bot mentioned this pull request Jun 4, 2024
Merged
6 tasks
@dataports dataports added the weekly-release Tagging backports for rapid release label Jun 4, 2024
@dataports
Copy link
Contributor

This is intended for v127.1

@pascalchevrel pascalchevrel merged commit 445909b into release/v127 Jun 17, 2024
3 of 5 checks passed
@pascalchevrel pascalchevrel deleted the mergify/bp/release/v127/pr-20539 branch June 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattreaganmozilla mattreaganmozilla Awaiting requested review from mattreaganmozilla mattreaganmozilla is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dataports @pascalchevrel