Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9309 - Download PDF Main Menu #20754

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add FXIOS-9309 - Download PDF Main Menu #20754

merged 1 commit into from
Jun 25, 2024

Conversation

DanielDervishi
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Added the ability to download pdfs easier from the main menu

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-21.at.14.45.55.mp4

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@DanielDervishi DanielDervishi requested a review from a team as a code owner June 21, 2024 21:25
@DanielDervishi DanielDervishi requested review from nbhasin2, OrlaM and adudenamedruby and removed request for nbhasin2 June 21, 2024 21:25
@adudenamedruby
Copy link
Contributor

@DanielDervishi, you have access to BR to start builds, right?

@dataports dataports closed this Jun 24, 2024
@dataports dataports reopened this Jun 24, 2024
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 31.89%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 30.5

File Coverage
BrowserViewController+TabToolbarDelegate.swift 11.9% ⚠️
MainMenuActionHelper.swift 40.5% ⚠️

Generated by 🚫 Danger Swift against d4696f3

@adudenamedruby adudenamedruby merged commit 541c821 into mozilla-mobile:main Jun 25, 2024
10 of 11 checks passed
@dataports
Copy link
Contributor

@Mergifyio backport release/v128

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024 •
edited
Loading

backport release/v128

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@DanielDervishi @mergify
Add FXIOS-9309 - Download PDF Main Menu (#20754)
a0bf33a 
Co-authored-by: Daniel Dervishi <ddervishi@CC7H24PK6P.local>
(cherry picked from commit 541c821)
@mergify mergify bot mentioned this pull request Jun 27, 2024
Closed
6 tasks
clarmso pushed a commit to clarmso/firefox-ios that referenced this pull request Jun 27, 2024
@DanielDervishi @clarmso
Add FXIOS-9309 - Download PDF Main Menu (mozilla-mobile#20754)
40acf1a 
Co-authored-by: Daniel Dervishi <ddervishi@CC7H24PK6P.local>
clarmso pushed a commit to clarmso/firefox-ios that referenced this pull request Jun 27, 2024
@DanielDervishi @clarmso
Add FXIOS-9309 - Download PDF Main Menu (mozilla-mobile#20754)
30afb68 
Co-authored-by: Daniel Dervishi <ddervishi@CC7H24PK6P.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrlaM OrlaM OrlaM approved these changes

@adudenamedruby adudenamedruby Awaiting requested review from adudenamedruby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DanielDervishi @adudenamedruby @mobiletest-ci-bot @dataports @OrlaM