Bug 1311945 - The menu should not be displayed when foregrounding the app on iPads #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app on iPads - dismiss menu on all form factors when app is resigning active this conforms with expected iOS behavior.
sleroux
pushed a commit
that referenced
this pull request
Dec 23, 2016
jjSDET
pushed a commit
to jjSDET/firefox-ios
that referenced
this pull request
Feb 13, 2024
…obile#2289) * For mozilla-mobile#2281 - Fix Full Functional test Refresh * add iPad condition to successfully run the tests there * a few more checks Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
isabelrios
added a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
…obile#2289) * For mozilla-mobile#2281 - Fix Full Functional test Refresh * add iPad condition to successfully run the tests there * a few more checks Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu now dismisses on the app preparing to resign active, which is consistent with other iOS behaviors.
As per discussion, implemented on both form factors, not just iPad.