Bug 1344783 - Make the highlight cells have similar favicons to TopSites #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhanpatel
suggested changes
Mar 6, 2017
| self.siteImageView.image = FaviconFetcher.getDefaultFavicon(url) | ||
| self.siteImageView.backgroundColor = FaviconFetcher.getDefaultColor(url) | ||
| } | ||
| self.siteImageView.setIcon(site.icon, forURL: URL(string: (site.icon?.url ?? site.url)), completed: { (color, url) in |
There was a problem hiding this comment.
You can use the method that lets you pass the site in. That should work instead of you having to use this method.
| self.siteImageView.backgroundColor = FaviconFetcher.getDefaultColor(url) | ||
| } | ||
| self.siteImageView.setIcon(site.icon, forURL: URL(string: (site.icon?.url ?? site.url)), completed: { (color, url) in | ||
| self.siteImageView.image = self.siteImageView.image?.createScaled(CGSize(width: 32, height: 32)) |
There was a problem hiding this comment.
Use weak self here. We've had a crash related to this before.
Also the CGSize(32,32) should be a UX static var.
| } | ||
| self.siteImageView.setIcon(site.icon, forURL: URL(string: (site.icon?.url ?? site.url)), completed: { (color, url) in | ||
| self.siteImageView.image = self.siteImageView.image?.createScaled(CGSize(width: 32, height: 32)) | ||
| self.siteImageView.contentMode = .center |
There was a problem hiding this comment.
You shouldnt need to center it in the closure. You can do this outside
|
Also do you need to do this in the other Highlight cell too? |
bkmunar
force-pushed
the
bkmunar/faviconHighlights
branch
from
a00ac60
to
1a497b8
Compare
farhanpatel
approved these changes
Mar 6, 2017
jjSDET
pushed a commit
to jjSDET/firefox-ios
that referenced
this pull request
Feb 13, 2024
…heme Settings (mozilla-mobile#2621) * Fixes mozilla-mobile#2496 - Collect Telemetry for Light / Dark Mode Theme Settings * Fixes mozilla-mobile#2496 - Collect Telemetry for Light / Dark Mode Theme Settings Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
…heme Settings (mozilla-mobile#2621) * Fixes mozilla-mobile#2496 - Collect Telemetry for Light / Dark Mode Theme Settings * Fixes mozilla-mobile#2496 - Collect Telemetry for Light / Dark Mode Theme Settings Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.