Bug 1385986 — Tell FxA that we've signed out. #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justindarc
approved these changes
Sep 29, 2017
jhugman
deleted the
jhugman/Bug1385986—account-device-destroy-fxa-on-disconnect
branch
st3fan
pushed a commit
that referenced
this pull request
Oct 3, 2017
jhreis
pushed a commit
to jhreis/firefox-ios
that referenced
this pull request
Oct 23, 2017
adudenamedruby
added a commit
that referenced
this pull request
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pursuit of fixing the bug about device_disconnected not working between iOS devices, this PR hits the /account/device/destroy endpoint to tell FxA that you've signed out. This in turn notifies other devices.
Thus, we should see a tidied list in the settings/clients page.
Regrettably, Synced Tabs will still continue to show the device in desktop.
https://bugzilla.mozilla.org/show_bug.cgi?id=1385986