Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Commit

Permalink
Closes #2805 - review: Replace maybeGoBackBeforeFxaSignIn with crash …
Browse files Browse the repository at this point in the history
…on gecko.

From Severin:
> I would replace this with a crash. If we ever move to GV, we'll want
> to know about this sooner rather than later. We can always comment it
> out at that time if it's considered low priority.
  • Loading branch information
mcomella committed Sep 27, 2019
1 parent 908b7b5 commit 5cac3e6
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions app/src/gecko/java/org/mozilla/tv/firefox/ext/EngineView.kt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import android.webkit.ValueCallback
import android.widget.FrameLayout
import androidx.annotation.VisibleForTesting
import mozilla.components.concept.engine.EngineView
import mozilla.components.support.base.log.logger.Logger
import org.mozilla.geckoview.GeckoView
import org.mozilla.geckoview.ScreenLength
import org.mozilla.tv.firefox.ext.Js.CACHE_JS
Expand All @@ -24,8 +23,6 @@ import java.util.WeakHashMap
// Extension methods on the EngineView class. This is used for additional features that are not part
// of the upstream browser-engine(-gecko) component yet.

private val logger = Logger("GeckoEngineView")

private val uiHandler = Handler(Looper.getMainLooper())

/**
Expand Down Expand Up @@ -181,7 +178,7 @@ val EngineView.backForwardList: WebHistory
get() = WebHistory

fun EngineView.maybeGoBackBeforeFxaSignIn() {
logger.warn("maybeGoBackBeforeFxaSignIn not implemented")
TODO("implemented only with system WebView to speed up development")
}

val EngineView.focusedDOMElement: FocusedDOMElementCache
Expand Down

0 comments on commit 5cac3e6

Please sign in to comment.