Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

[FxA] Return user to page they started on after sign in #2805

Closed
mcomella opened this issue Sep 5, 2019 · 2 comments
Closed

[FxA] Return user to page they started on after sign in #2805

mcomella opened this issue Sep 5, 2019 · 2 comments
Assignees
@mcomella
Labels
feature qa-approved Should size S 2 pt = 1 day = 6 - 8 hours
Projects
FFTV & FFES Roadmap

Comments

@mcomella
Copy link
Contributor

mcomella commented Sep 5, 2019 •
edited by athomasmoz

Why/User Benefit/User Problem

We have one WebView and we use the WebView to sign into FxA so whatever page the user was looking at gets replaced by the sign in process, even after successful sign in. It's in their back stack so in theory they can still press back to see the page but it's unintuitive to go back through the sign in flow to get there.

Ideally, the sign in flow wouldn't disrupt the user's browsing experience.

Acceptance Criteria (how do I know when I’m done?)

  • After successful sign in (which may require successful email confirmation), the website the user was on before sign in is restored

Not included

  • If the user does not complete sign in, the the user was on before sign in is restored (mcomella: because I'm not sure how feasible this is)
@mcomella mcomella changed the title Return user to page they started on after sign in [FxA] Return user to page they started on after sign in Sep 5, 2019
@athomasmoz athomasmoz added the size S 2 pt = 1 day = 6 - 8 hours label Sep 6, 2019
@severinrudie severinrudie self-assigned this Sep 16, 2019
severinrudie added a commit to severinrudie/firefox-tv that referenced this issue Sep 16, 2019
@severinrudie
Issue mozilla-mobile#2805: skeleton for back out after fxa sign in
0f4f432
@severinrudie severinrudie removed their assignment Sep 17, 2019
@psymoon psymoon assigned psymoon and unassigned psymoon Sep 18, 2019
@mcomella mcomella self-assigned this Sep 25, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 25, 2019
@mcomella
Issue mozilla-mobile#2805: Add MockWebBackForwardList.
428a405
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 25, 2019
@mcomella
Issue mozilla-mobile#2805: Add WebBackForwardList.toList.
f0efd07 
This code is adapted from Severin's WIP:
severinrudie@0f4f432
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 25, 2019
@mcomella
Issue mozilla-mobile#2805: Add EngineView.maybeGoBackBeforeFxaSignIn.
82c9079
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 25, 2019
@mcomella
Issue mozilla-mobile#2805: Add onFxaLoginSuccess event.
201b9b6
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 25, 2019
@mcomella
Closes mozilla-mobile#2805: Hook up onFxaLoginSuccess to maybeGoBack.
05f5079 
I verified:
- The log in happy path
- The email validation path
- The "blocked" email validation path
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 25, 2019
@mcomella
Closes mozilla-mobile#2805: Add CHANGELOG entry for fxa sign in resto…
5351bbe 
…ration.
@mcomella
Copy link
Contributor Author

QA: after the user successfully signs in, the browser should update to the page the user was on before sign in: please verify this behavior. Note that the user will have to first close onboarding and then close the overlay to see the web content with the restored page.

@mcomella mcomella added this to To be triaged in FFTV & FFES Roadmap via automation Sep 26, 2019
@mcomella mcomella moved this from To be triaged to In Progress in FFTV & FFES Roadmap Sep 26, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 26, 2019
@mcomella
Closes mozilla-mobile#2805 - review: Rename MockWebBackForwardList to…
144dc8c 
… FakeWebBackForwardList.
mcomella added a commit to mcomella/firefox-tv that referenced this issue Sep 26, 2019
@mcomella
Closes mozilla-mobile#2805 - review: Replace maybeGoBackBeforeFxaSign…
f632e22 
…In with crash on gecko.

From Severin:
> I would replace this with a crash. If we ever move to GV, we'll want
> to know about this sooner rather than later. We can always comment it
> out at that time if it's considered low priority.
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Issue #2805: Add MockWebBackForwardList.
997760a
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Issue #2805: Add WebBackForwardList.toList.
907d31e 
This code is adapted from Severin's WIP:
severinrudie@0f4f432
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Issue #2805: Add EngineView.maybeGoBackBeforeFxaSignIn.
363e502
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Issue #2805: Add onFxaLoginSuccess event.
f80d0ca
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Closes #2805: Add CHANGELOG entry for fxa sign in restoration.
5280d3b
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Closes #2805 - review: Rename MockWebBackForwardList to FakeWebBackFo…
908b7b5 
…rwardList.
mcomella added a commit that referenced this issue Sep 27, 2019
@mcomella
Closes #2805 - review: Replace maybeGoBackBeforeFxaSignIn with crash …
5cac3e6 
…on gecko.

From Severin:
> I would replace this with a crash. If we ever move to GV, we'll want
> to know about this sooner rather than later. We can always comment it
> out at that time if it's considered low priority.
FFTV & FFES Roadmap automation moved this from In Progress to QA Needed Sep 27, 2019
@abodea
Copy link
Member

abodea commented Nov 7, 2019

Verified as fixed in FFTV 4.5 note that after a successfully login, I was redirected to the menu overview and the Your tabs. Now ready for prime time overlay prompt was displayed, and after closing it the menu overview was displayed.

@abodea abodea moved this from QA Needed to Done in FFTV & FFES Roadmap Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
feature qa-approved Should size S 2 pt = 1 day = 6 - 8 hours
Projects
No open projects
FFTV & FFES Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mcomella @psymoon @severinrudie @abodea @athomasmoz