Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Make blocking code honor blocking settings #20

Closed
pocmo opened this issue Jan 26, 2017 · 0 comments
Closed

Make blocking code honor blocking settings #20

pocmo opened this issue Jan 26, 2017 · 0 comments
Labels
feature
Milestone
1.0

Comments

@pocmo
Copy link
Contributor

pocmo commented Jan 26, 2017

No description provided.

@pocmo pocmo added the feature label Jan 26, 2017
@st3fan st3fan added the v1.0 label Feb 15, 2017
@pocmo pocmo mentioned this issue Feb 15, 2017
Closed
@ahunt ahunt self-assigned this Feb 17, 2017
ahunt added a commit that referenced this issue Feb 21, 2017
@ahunt
Store blocklist categories separately (#20)
8174e6e 
We still need to link this with settings (by default all categories
are enabled), but we can now store each category in a separate list,
and enable/disable as needed.
ahunt added a commit that referenced this issue Feb 21, 2017
@ahunt
Add keys to preferences, intialise with default values at startup (#20)
d6b8ded 
Defining the actual keys separately means we can reuse that definition
when reading preferences in code. We need to provide a default
value for every key so that they are correctly initialised during startup.
ahunt added a commit that referenced this issue Feb 21, 2017
@ahunt
Make preferences localisable (#20)
980c1c6
ahunt added a commit that referenced this issue Feb 21, 2017
@ahunt
Link blocklist categories to preferences (#20)
91fcc61 
This patch also adds some blocklist rewriting: some items in the
"Disconnect" list are moved to "Social", the remainder are discarded.
@ahunt ahunt added this to the Sprint 1 milestone Feb 22, 2017
@ahunt ahunt mentioned this issue Feb 22, 2017
Closed
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Store blocklist categories separately (#20)
865a60c 
We still need to link this with settings (by default all categories
are enabled), but we can now store each category in a separate list,
and enable/disable as needed.
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Add keys to preferences, intialise with default values at startup (#20)
5417b57 
Defining the actual keys separately means we can reuse that definition
when reading preferences in code. We need to provide a default
value for every key so that they are correctly initialised during startup.
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Make preferences localisable (#20)
8d8b4e1
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Link blocklist categories to preferences (#20)
81c5568 
This patch also adds some blocklist rewriting: some items in the
"Disconnect" list are moved to "Social", the remainder are discarded.
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Store blocklist categories separately (#20)
834ba7d 
We still need to link this with settings (by default all categories
are enabled), but we can now store each category in a separate list,
and enable/disable as needed.
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Add keys to preferences, intialise with default values at startup (#20)
f00bebf 
Defining the actual keys separately means we can reuse that definition
when reading preferences in code. We need to provide a default
value for every key so that they are correctly initialised during startup.
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Make preferences localisable (#20)
d0b2a4b
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Link blocklist categories to preferences (#20)
159128e 
This patch also adds some blocklist rewriting: some items in the
"Disconnect" list are moved to "Social", the remainder are discarded.
@ahunt ahunt closed this as completed Feb 22, 2017
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Don't read preference value until we have to
a967077 
This is a followup to #20. On my 5.1 device, and "App Restriction"
preference is changed when a WebView is opened. We would then crash,
since that pref is a String. The same preference doesn't get changed
(and/or isn't ever set) on a 7.0 device.
@ahunt ahunt mentioned this issue Feb 22, 2017
Merged
ahunt added a commit that referenced this issue Feb 22, 2017
@ahunt
Only move Twitter/FB from "Disconnect"/"Social"
01888ad 
I forgot to implement the filtering of other sites in #20. Only
Twitter and FB remain, and are moved into "Social". Google is added in a
separate list (#94). That only leaves itisatracker.com which is unneeded.
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Add configuration for android2po. (#20)
b916357
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Make strings more descriptive for translation. (#20)
8412661
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Add configuration for android2po. (#20)
560b908
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Make strings more descriptive for translation. (#20)
cf3b82b
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Add configuration for android2po. (#20)
e8f3f51
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Make strings more descriptive for translation. (#20)
395d1ab
ahunt added a commit that referenced this issue Feb 23, 2017
@ahunt
Only move Twitter/FB from "Disconnect"/"Social"
b69c70b 
I forgot to implement the filtering of other sites in #20. Only
Twitter and FB remain, and are moved into "Social". Google is added in a
separate list (#94). That only leaves itisatracker.com which is unneeded.
ahunt added a commit that referenced this issue Feb 23, 2017
@ahunt
Don't read preference value until we have to
7b5206e 
This is a followup to #20. On my 5.1 device, and "App Restriction"
preference is changed when a WebView is opened. We would then crash,
since that pref is a String. The same preference doesn't get changed
(and/or isn't ever set) on a 7.0 device.
ahunt added a commit that referenced this issue Feb 23, 2017
@ahunt
Only move Twitter/FB from "Disconnect"/"Social"
d483dff 
I forgot to implement the filtering of other sites in #20. Only
Twitter and FB remain, and are moved into "Social". Google is added in a
separate list (#94). That only leaves itisatracker.com which is unneeded.
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Make strings more descriptive for translation. (#20)
a49e92b
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Add configuration for android2po. (#20)
7d35e40
pocmo added a commit that referenced this issue Feb 23, 2017
@pocmo
Make strings more descriptive for translation. (#20)
cf06096
@pocmo pocmo modified the milestone: 1.0 Jul 26, 2017
@pocmo pocmo unassigned ahunt Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@st3fan @pocmo @ahunt