Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Inconsistencies in string use: "Custom URLs" vs "Custom URL" #2343

Closed
Delphine opened this issue Mar 19, 2018 · 6 comments
Closed

Inconsistencies in string use: "Custom URLs" vs "Custom URL" #2343

Delphine opened this issue Mar 19, 2018 · 6 comments
Assignees
Milestone

Comments

@Delphine
Copy link
Contributor

It seems like there are inconsistencies in the app between "Custom URLs" and "Custom URL".
Flod mentioned that the header used here, with single case, sounds particularly confusing to him:
https://npark-mozilla.github.io/en-US/images/phoneScreenshots/Autocomplete_Menu_Item_1521232078475.png

So we wanted to make sure these inconsistencies were expected or not?
You can find the list of occurrences for both here: https://transvision.mozfr.org/?recherche=custom+url&repo=focus_android&sourcelocale=en-US&locale=fr&search_type=strings

@Delphine
Copy link
Contributor Author

(CC @lime124 in case you can help clarify! Don't know if I should be pinging someone else as well)

@lime124
Copy link
Collaborator

lime124 commented Mar 20, 2018

@BrianNJones it does seem like the header should be URLs (plural). Thoughts?

For the other cases, if I recall the add custom url was left singular because you are only adding one URL at a time. Though I can't recall the difference between + Add custom URL and Add custom URL.

Same thing for the last string New custom URL added. - it's displayed in a toast to indicate the URL the person entered (singular) was successfully added.

/cc @brampitoyo

@brampitoyo
Copy link

Feels like “Custom URLs” is the right word to use, but this is a hard one for me as a non-native speaker. I will agree with the consistent word that @BrianNJones will propose.

@bbinto bbinto modified the milestones: v4.2, Reserve Backlog Mar 20, 2018
@bbinto bbinto added the P2 label Mar 20, 2018
@bbinto bbinto modified the milestones: Reserve Backlog, v4.2 Mar 20, 2018
@BrianNJones
Copy link

@brampitoyo Agree. This s/b "Custom URLs"

@ekager ekager self-assigned this Mar 26, 2018
@ekager
Copy link
Contributor

ekager commented Mar 26, 2018

Hi @Delphine, will it cause any l10n issues if I just replace this string with the preference_autocomplete_subitem_customlist = "Custom URLs" string?

ekager pushed a commit to ekager/focus-android that referenced this issue Mar 26, 2018
@Delphine
Copy link
Contributor Author

@ekager: Unfortunately that won't work because the existing string exists in a different context. We'll need a new string for this.
Thank you!

ekager pushed a commit to ekager/focus-android that referenced this issue Mar 27, 2018
ekager pushed a commit to ekager/focus-android that referenced this issue Mar 28, 2018
ekager pushed a commit to ekager/focus-android that referenced this issue Mar 28, 2018
ekager pushed a commit to ekager/focus-android that referenced this issue Mar 28, 2018
@boek boek closed this as completed in dca61c4 Mar 29, 2018
@ekager ekager added the QAReady flag for test read & needed label Apr 9, 2018
@rpappalax rpappalax removed the QAReady flag for test read & needed label Aug 9, 2018
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Dec 13, 2022
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Dec 13, 2022
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Dec 13, 2022
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Dec 13, 2022
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Dec 13, 2022
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Dec 13, 2022
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants