-
Notifications
You must be signed in to change notification settings - Fork 710
-
Notifications
You must be signed in to change notification settings - Fork 710
Inconsistencies in string use: "Custom URLs" vs "Custom URL" #2343
Comments
(CC @lime124 in case you can help clarify! Don't know if I should be pinging someone else as well) |
@BrianNJones it does seem like the header should be URLs (plural). Thoughts? For the other cases, if I recall the add custom url was left singular because you are only adding one URL at a time. Though I can't recall the difference between + Add custom URL and Add custom URL. Same thing for the last string New custom URL added. - it's displayed in a toast to indicate the URL the person entered (singular) was successfully added. /cc @brampitoyo |
Feels like “Custom URLs” is the right word to use, but this is a hard one for me as a non-native speaker. I will agree with the consistent word that @BrianNJones will propose. |
@brampitoyo Agree. This s/b "Custom URLs" |
Hi @Delphine, will it cause any l10n issues if I just replace this string with the |
@ekager: Unfortunately that won't work because the existing string exists in a different context. We'll need a new string for this. |
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@1ea7554 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@1ea7554 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@1ea7554 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@1ea7554 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@1ea7554 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@1ea7554 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
…e/focus-android#2343 X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@180e040
It seems like there are inconsistencies in the app between "Custom URLs" and "Custom URL".
Flod mentioned that the header used here, with single case, sounds particularly confusing to him:
https://npark-mozilla.github.io/en-US/images/phoneScreenshots/Autocomplete_Menu_Item_1521232078475.png
So we wanted to make sure these inconsistencies were expected or not?
You can find the list of occurrences for both here: https://transvision.mozfr.org/?recherche=custom+url&repo=focus_android&sourcelocale=en-US&locale=fr&search_type=strings
The text was updated successfully, but these errors were encountered: