Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Don't animate the toolbar if a11y services are enabled #5509

Closed
delia-pop opened this issue Sep 29, 2021 · 5 comments
Closed

Don't animate the toolbar if a11y services are enabled #5509

delia-pop opened this issue Sep 29, 2021 · 5 comments
Assignees
@ionutbedregeanu
Labels
bug QAVerified
Projects
Android Focus Android Engineering Team Kanban board
Milestone
95

Comments

@delia-pop
Copy link

Steps to reproduce

  1. Enable Talkback on your device.
  2. Launch Firefox Focus.
  3. Open 2 or more web pages, load one with content that must be scrolled (i.e. cnn.com).
  4. Scroll down page using talkback gestures.
  5. Observe the tab manager icon.

Expected behavior

The tab manager icon remains present at all times when Talkback is enabled.

Actual behavior

The tab manager icon disappears when scrolling down using the talkback gestures.

Device information

  • Android device: Huawei P9 Lite (Android 8).
  • Focus version: RC 93.1.0 ( Build 352720228 GV - 93.0.20210927210923).
The.tab.manager.icon.disappears.when.scrolling.using.the.Talkback.gestures.mp4
@ionutbedregeanu ionutbedregeanu self-assigned this Oct 1, 2021
@ionutbedregeanu ionutbedregeanu added this to Backlog in Android Focus via automation Oct 4, 2021
@ionutbedregeanu ionutbedregeanu moved this from Backlog to In Progress in Android Focus Oct 4, 2021
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 4, 2021
For mozilla-mobile#5509 - Show floating buttons when TalkBack is enabled
09c6efa
@ionutbedregeanu ionutbedregeanu mentioned this issue Oct 4, 2021
Merged
@ionutbedregeanu ionutbedregeanu added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Oct 4, 2021
@ionutbedregeanu ionutbedregeanu moved this from Ready for Engineering (min-5 ; max-22) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Oct 4, 2021
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 5, 2021
For mozilla-mobile#5509 - Show floating buttons when TalkBack is enabled
20be2ea
@Mugurell
Copy link
Contributor

Mugurell commented Oct 5, 2021

There's a bigger issue here: the toolbar should not be animated if there's an a11y service enabled.
If we're to fix this the FABs would stay on the screen also.
Fenix for reference:

@Mugurell
Copy link
Contributor

Mugurell commented Oct 5, 2021

Will also update the title.

@Mugurell Mugurell changed the title The tab manager icon disappears when scrolling using the Talkback gestures Don't animate the toolbar if a11y services are enabled Oct 5, 2021
@ionutbedregeanu ionutbedregeanu moved this from Dev Complete (WIP limit - 5) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Oct 5, 2021
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 5, 2021
For mozilla-mobile#5509 - Show the toolbar and floating buttons when …
4fc74d9 
…TalkBack is enabled
@ionutbedregeanu ionutbedregeanu moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Oct 5, 2021
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 6, 2021
For mozilla-mobile#5509 - Show the toolbar and floating buttons when …
85a5691 
…a11y services are enabled
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 8, 2021
For mozilla-mobile#5509 - Show the toolbar and floating buttons when …
6347c3d 
…a11y services are enabled
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 8, 2021
For mozilla-mobile#5509 - Show the toolbar and floating buttons when …
a610ecc 
…a11y services are enabled
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 8, 2021
For mozilla-mobile#5509 - Show the toolbar and floating buttons when …
af3c077 
…a11y services are enabled
mergify bot pushed a commit that referenced this issue Oct 8, 2021
@mergify
For #5509 - Show the toolbar and floating buttons when a11y services …
237b103 
…are enabled
@ionutbedregeanu ionutbedregeanu added the QAReady flag for test read & needed label Oct 8, 2021
@ionutbedregeanu ionutbedregeanu moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Oct 8, 2021
@delia-pop
Copy link
Author

Verified as fixed on the latest debug build from main from 10/11 (build 11 GV 95.0a1-20211005094529), with Huawei P9 Lite (Android 8).
The tab manager icon remains on screen at all times and the toolbar is no longer animated when Talkback is enabled.

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Oct 11, 2021
Android Focus automation moved this from In Progress to Done Oct 11, 2021
@AndiAJ AndiAJ added QAVerified and removed QAReady flag for test read & needed labels Oct 11, 2021
jonalmeida pushed a commit to jonalmeida/focus-android that referenced this issue Oct 15, 2021
@jonalmeida
For mozilla-mobile#5509 - Show the toolbar and floating buttons when …
da57411 
…a11y services are enabled
@delia-pop
Copy link
Author

Reopening the issue as it is Still Present on the Beta 94.0.0 (build 352862025 GV 94.0-20211005185813), with Huawei P9 Lite (Android 8).
The toolbar is still animated and the tab manager icon disappears when scrolling down using the talkback gestures.

Note that on this does not occur on the latest Focus Nightly from 10/15 95.0 (Build #352880510) 95.0a1-20211007091917).

Animated.toolbar.with.talkback.gestures.mp4

@delia-pop delia-pop reopened this Oct 15, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Oct 15, 2021
Android Focus automation moved this from Done to Backlog Oct 15, 2021
mergify bot pushed a commit that referenced this issue Oct 15, 2021
@mergify
For #5509 - Show the toolbar and floating buttons when a11y services …
72451d6 
…are enabled
@delia-pop
Copy link
Author

Verified as fixed on Beta 94.0.0-beta.2 (build 352922038 GV 94.0-20211017185800) and latest debug build from main 10/20 with Huawei P9 Lite (Android 8).

Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done Oct 20, 2021
Android Focus automation moved this from Backlog to Done Oct 20, 2021
@amedyne amedyne added this to the 95 milestone Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ionutbedregeanu ionutbedregeanu

Labels
bug QAVerified
Projects
Android Focus
  
Done
Android Engineering Team Kanban board
Done
Milestone
95
Development

No branches or pull requests
6 participants
@Mugurell @ionutbedregeanu @lobontiumira @AndiAJ @amedyne @delia-pop