Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

The search field includes the three-dot menu after selecting the URL #5582

Closed
lobontiumira opened this issue Oct 11, 2021 · 2 comments
Closed

Comments

@lobontiumira
Copy link

Steps to reproduce

  1. Open a page.
  2. Tap on the search field, the page's address is selected.
  3. Tap back, the page reloads.
  4. Observe the search field and the three-dot menu.

Expected behavior

The three-dot menu is displayed in the right upper corner, and it is not included in the search field.

Actual behavior

The search field includes briefly the three-dot menu.

Device information

  • Android device: Google Pixel (Android 10)
  • Focus version: the latest debug build from 10/11 (build 11 GV 95.0a1-20211005094529), and 93.1.1.
  • If the light theme is selected, the three-dot menu is not visible.
three-dot_Trim.mp4

Slow-motion - light theme:

20211011_233707_Slomo.mp4
@ionutbedregeanu ionutbedregeanu self-assigned this Oct 12, 2021
@ionutbedregeanu ionutbedregeanu added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Oct 12, 2021
@ionutbedregeanu ionutbedregeanu added this to Backlog in Android Focus via automation Oct 12, 2021
@ionutbedregeanu ionutbedregeanu moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Oct 12, 2021
@ionutbedregeanu ionutbedregeanu moved this from Backlog to In Progress in Android Focus Oct 12, 2021
ionutbedregeanu pushed a commit to ionutbedregeanu/focus-android that referenced this issue Oct 13, 2021
…Fragment

EditToolbar background needs to be set only in UrlInputFragment because on
BrowserFragment we are using only the DisplayToolbar
@ionutbedregeanu ionutbedregeanu moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Oct 13, 2021
@mcarare mcarare added the QAReady flag for test read & needed label Oct 14, 2021
@mcarare mcarare moved this from In Progress to Done in Android Focus Oct 14, 2021
mergify bot pushed a commit that referenced this issue Oct 14, 2021
EditToolbar background needs to be set only in UrlInputFragment because on
BrowserFragment we are using only the DisplayToolbar
@ionutbedregeanu ionutbedregeanu moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Oct 14, 2021
@ionutbedregeanu ionutbedregeanu moved this from Done to In Progress in Android Focus Oct 14, 2021
jonalmeida pushed a commit to jonalmeida/focus-android that referenced this issue Oct 15, 2021
…Fragment

EditToolbar background needs to be set only in UrlInputFragment because on
BrowserFragment we are using only the DisplayToolbar
mergify bot pushed a commit that referenced this issue Oct 15, 2021
EditToolbar background needs to be set only in UrlInputFragment because on
BrowserFragment we are using only the DisplayToolbar
@lobontiumira
Copy link
Author

lobontiumira commented Oct 15, 2021

Verified as fixed on the latest debug build from main from 10/15 with Google Pixel (Android 10).

Still reproducible on the Beta 94.0.0-beta.1, so I'll leave this ticket opened until the fix is uplifted there too.

@lobontiumira lobontiumira added QAVerified and removed QAReady flag for test read & needed labels Oct 15, 2021
@lobontiumira
Copy link
Author

Verified as fixed on Beta 94.0.0-beta.2 (build 352922038 GV 94.0-20211017185800) with Google Pixel (Android 10), and Sony Xperia Z5 Premium (Android 7.1.1).

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Oct 20, 2021
Android Focus automation moved this from In Progress to Done Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Android Focus
  
Done
Development

No branches or pull requests

3 participants