"Open in..." option doesn't display the debug Focus builds installed

[lobontiumira]

Prerequisites

Make sure you have at least two Firefox Focus builds installed, and at least one of them is a debug build.

Steps to reproduce

1. Install Beta 94.0.0-beta.1.
2. Open a page, and from the three-dot menu select the "Open in..." option.
3. Observe the installed apps displayed in the "Open in..." dialogue.

Expected behavior

All the installed apps that are suitable for opening the page are displayed.

Actual behavior

The Focus debug builds installed are not displayed at all.
I had the latest debug build from main from 10/15, and Firefox Focus Nightly.

Device information

• Android device: Lenovo Tab M10 (Android 10), Pixel 2 (Android 9)
• Not reproducible on Google Pixel (Android 10)
• Focus version: Beta 94.0.0-beta.1
• Focus Nightly, and the debug build display Focus Beta, but not each other.

[mcarare]

We should remove KnownBrowsers from Focus and use the one from AC. But I am not sure if that is updated either.
But I am not sure debug builds should show up either way.
cc @pocmo

[pocmo]

Agree, let's see if we can use the implementation from A-C. And yeah, we will have to add the new Focus Nightly/Beta builds to it too.

[lobontiumira]

Reproducible on Beta 94.0.0-beta.2 (build 352922038 GV 94.0-20211017185800) with Lenovo Tab M10 (Android 10).

[ionutbedregeanu]

@lobontiumira Can you please tell me if it's still reproducible? Because I didn't succeed to reproduce it

[lobontiumira]

Yes, I was able to reproduce on RC 94.1.1, and on Beta 94.0.0-beta.2 with Lenovo tabley M10 (Android 10).

[delia-pop]

Tested on Beta 95.0.0-beta.1 build and latest debug build from main 11/04 with Huawei P9 Lite (Android 8).

The issue is verified fixed on the debug build. With the debug build set as default browser, on both browser page and custom tab the suitable applications to open the page with are displayed: chrome, beta build and the debug build itself.

@ionutbedregeanu Please note that with the Beta 95.0.0-beta.1 build set as default browser, on both browser page and custom tab only the chrome and Debug build are displayed, without the Beta build itself.

[ionutbedregeanu]

I don't think we should show the current browser in Open in list. We should log a bug for that.

[lobontiumira]

This issue still reproduces on RC 95.1.0 with Lenovo tab M10 (Android 10), and Sony Xperia Z5 Premium (Android 7.1.1).

[lobontiumira]

This issue doesn't reproduce in Beta 96.0.0-beta.1, nor in Focus Nightly from 12/7.
It only reproduces on RC 95.1.0 with some devices, like Sony Xperia Z5 Premium (Android 7.1.1), and LEnovo tablet M10 (Android 10):

Note: it does not reproduce on RC 95.1.0 on the following devices:

• Samsung Galaxy Note10 (Android 11)
• LG G7 fit (Android 8.1.0)
• Xiaomi Redmi Note 8T (Android 9)