Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add option to close tabs selectively. #5741

Closed
mcarare opened this issue Oct 29, 2021 · 4 comments
Closed

Add option to close tabs selectively. #5741

mcarare opened this issue Oct 29, 2021 · 4 comments
Labels
feature request QAVerified
Milestone
96

Comments

@mcarare
Copy link
Contributor

mcarare commented Oct 29, 2021

Why/User Benefit/User Problem

Users do not have the option to close just one or more, not all opened tabs.

What / Requirements

Add a close button to items in the session list.

Acceptance Criteria (how do I know when I’m done?)

Users have the option to close tabs selectively.

P.S.: This request was also encountered in play store reviews.
@mcarare
Copy link
Contributor Author

mcarare commented Oct 29, 2021

cc @channingcarter, @brampitoyo

This is dependable on the multitabs decision.

@OysterP
Copy link

OysterP commented Oct 29, 2021

Already raised under #5445

@mcarare mcarare mentioned this issue Nov 1, 2021
Closed
@kelimuttu
Copy link

We've seen a request to have this feature from the Google Play Store.

@pocmo pocmo mentioned this issue Dec 7, 2021
Closed
mergify bot pushed a commit that referenced this issue Dec 7, 2021
@mcarare @mergify
For #5741: Add option to close sessions selectively.
3ab7190 
Refactor TabsAdapter to implement ListAdapter.
Refactor TabViewHolder.
Remove state observing and pass initial tab list:
The tab list and the selected tab do not change while fragment is displayed.
mergify bot pushed a commit that referenced this issue Dec 7, 2021
@mcarare @mergify
For #5741: Update UI test to reflect new view hierarchy.
e6b4dd7
@mcarare mcarare added this to the 96 milestone Dec 7, 2021
@mcarare mcarare added QAReady flag for test read & needed and removed UX waiting labels Dec 7, 2021
@lobontiumira
Copy link

Verified as fixed on the latest Focus Nightly build from 12/8, and on Beta 96.0.0-beta.1 with multiple devices:

  • Sony Xperia Z5 Premium (Android 7.1.1),
  • Samsung Galaxy Tab A6 (Android 5.1.1),
  • Xiaomi mi4i (Android 5.0.2),
  • Google Pixel (Android 10),
  • Lenovo tablet M10 (Android 10).

The tabs can be closed in any order. If the user selects to close the active tab, the next teb under it is loading and displayed.
Switching from portrait to landscape and viceversa while the tabs list is displayed, keeps the tabs list displayed, does not dismiss it.

5741 landscape

5741 portrait

@lobontiumira lobontiumira added QAVerified and removed QAReady flag for test read & needed labels Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature request QAVerified
Projects
None yet
Milestone
96
Development

No branches or pull requests
4 participants
@kelimuttu @lobontiumira @mcarare @OysterP