Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Use locale neutral links to SUMO KB articles #4586

Merged
merged 3 commits into from Mar 15, 2021
Merged

Use locale neutral links to SUMO KB articles #4586

merged 3 commits into from Mar 15, 2021

Conversation

MikkCZ
Copy link
Contributor

@MikkCZ MikkCZ commented Jul 3, 2020

fix #3466

I hope it's that simple. Can you please check @jonalmeida ? It's a small patch and I believe quite safe to merge whatever the state of Focus development is right now.

Thank you.

@MikkCZ MikkCZ changed the title Use language neutral links to SUMO KB articles Use loclae neutral links to SUMO KB articles Jul 4, 2020
@MikkCZ MikkCZ changed the title Use loclae neutral links to SUMO KB articles Use locale neutral links to SUMO KB articles Jul 4, 2020
Copy link

@yanmakazuki yanmakazuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks working good in Japanese and some other languages

@pocmo pocmo closed this Mar 12, 2021
@MikkCZ
Copy link
Contributor Author

MikkCZ commented Mar 12, 2021

Hi @pocmo .

May I ask why was this simple PR closed? I know it's stale, but still I would like this issue to be solved.

@pocmo
Copy link
Contributor

pocmo commented Mar 15, 2021

@MikkCZ Sorry, we had to mass-close PRs from the last years to be able to restart this project. This here totally makes sense and is simple. I'll reopen this PR.

@pocmo pocmo reopened this Mar 15, 2021
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out the new links, LGTM! ✅

@jonalmeida jonalmeida added the 🛬 needs landing PRs that are ready to land label Mar 15, 2021
@mergify mergify bot merged commit 321c380 into mozilla-mobile:master Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage tips links always open SUMO article in en-US
4 participants