This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Merge top site tab #7578
Merged
Merge top site tab #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalmeida
suggested changes
Sep 6, 2022
app/src/main/java/org/mozilla/focus/topsites/TopSitesOverlay.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/focus/tabs/MergeTabsMiddleware.kt
Outdated
Show resolved
Hide resolved
ionutbedregeanu
force-pushed
the
ionut.bedregeanu/5384
branch
from
897cc10
to
336b393
Compare
jonalmeida
approved these changes
Sep 7, 2022
| ) | ||
| } else { | ||
| components.sessionUseCases.loadUrl(item.url, currentTabId) | ||
| components.appStore.dispatch(AppAction.FinishEdit(currentTabId)) |
There was a problem hiding this comment.
Interesting, I see we do this in the UrlInputFragment as well even when we are dismissing it without action.
ionutbedregeanu
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5384
top_site.mp4
Pull Request checklist
QA
To download an APK when reviewing a PR:
Show All Checks,Detailsnext tobuild-focus-debugorbuild-klar-debugfor changes targeting Klar,View task in Taskcluster,Artifactsrow,GitHub Automation
Fixes #5384