Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fixes #1473: Fixes constraints on settings table cell #1593

Merged
merged 1 commit into from Nov 26, 2018

Conversation

janicelee
Copy link
Contributor

Addresses issue described in: #1473

Based on the implementation of the table headers, it seems like we can avoid making constraints based on textLabel and instead give the spacerView the same width as used for the table headers.

Note: Noticed recent changes to master might be causing problems in displaying the settings table cells , created a separate issue for this here: #1592

@mozillamobilebot
Copy link

SwiftLint found issues

Warnings

File Line Reason
SettingsViewController.swift 109 Lines should not have trailing whitespace.
SettingsViewController.swift 112 Lines should not have trailing whitespace.
SettingsViewController.swift 117 Lines should not have trailing whitespace.
SettingsViewController.swift 122 Lines should not have trailing whitespace.
SettingsViewController.swift 129 Lines should not have trailing whitespace.
SettingsViewController.swift 132 Lines should not have trailing whitespace.
SettingsViewController.swift 135 Lines should not have trailing whitespace.
SettingsViewController.swift 139 Lines should not have trailing whitespace.
SettingsViewController.swift 141 Lines should not have trailing whitespace.
SettingsViewController.swift 152 Lines should not have trailing whitespace.
SettingsViewController.swift 158 Lines should not have trailing whitespace.
SettingsViewController.swift 163 Lines should not have trailing whitespace.
SettingsViewController.swift 168 Lines should not have trailing whitespace.
SettingsViewController.swift 174 Lines should not have trailing whitespace.
SettingsViewController.swift 179 Lines should not have trailing whitespace.
SettingsViewController.swift 184 Lines should not have trailing whitespace.
SettingsViewController.swift 190 Lines should not have trailing whitespace.
SettingsViewController.swift 194 Lines should not have trailing whitespace.
SettingsViewController.swift 198 Lines should not have trailing whitespace.
SettingsViewController.swift 467 Lines should not have trailing whitespace.

Generated by 🚫 Danger

Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix (and for filing that other issue!)

@sblatz sblatz merged commit e805c4c into master Nov 26, 2018
@janicelee janicelee deleted the janicelee/fix-settings-constraints branch November 28, 2018 02:20
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 14, 2024
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants