Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Settings table view cells padding and text sizes are inconsistent #1592

Closed
janicelee opened this issue Nov 25, 2018 · 1 comment
Closed

Settings table view cells padding and text sizes are inconsistent #1592

janicelee opened this issue Nov 25, 2018 · 1 comment
Assignees
Labels
size S 1 day or less of work

Comments

@janicelee
Copy link
Contributor

janicelee commented Nov 25, 2018

On master, it seems that there are several problems with the appearance of the settings.

  • The padding of the cells is inconsistent ( "Use Touch ID" cell appears to have a larger padding than "Block Web fonts")
  • The text sizes are also inconsistent, particularly the "Send usage data" and "Get Search Suggestions" cells. This can be clearly seen when the dynamic font size is changed.

It appears that the problem was introduced in: #1578

Standard font size:
settings

Largest font size:
Note: the label constraints breaking seen below was already a problem (filed as issue #1473) before the changes that seem to be causing the problems detailed in this issue.

dynamictext

@janicelee janicelee changed the title Settings table view cells padding and text sizes are broken Settings table view cells padding and text sizes are inconsistent Nov 26, 2018
@sblatz
Copy link
Contributor

sblatz commented Nov 26, 2018

Good catch on these. A couple notes:

  • The Touch ID cell is missing the description text for some reason.
  • It seems like the send usage data and get search suggestions cells do not properly respect dynamic text, which causes the variance in text size.

@sblatz sblatz self-assigned this Nov 26, 2018
sblatz added a commit that referenced this issue Nov 26, 2018
@sblatz sblatz added this to the Focus iOS V8.0 milestone Nov 26, 2018
sblatz added a commit that referenced this issue Nov 27, 2018
sblatz added a commit that referenced this issue Nov 27, 2018
sblatz added a commit that referenced this issue Nov 27, 2018
sblatz added a commit that referenced this issue Nov 27, 2018
@sblatz sblatz added the size S 1 day or less of work label Nov 27, 2018
sblatz added a commit that referenced this issue Nov 27, 2018
@sblatz sblatz closed this as completed in 8c64c1f Nov 27, 2018
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size S 1 day or less of work
Projects
None yet
Development

No branches or pull requests

2 participants