Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1169: Add a test for the no internet connection page #1644

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@klymenkoo
Copy link
Contributor

klymenkoo commented Feb 14, 2019

This PR contains a fix for #1164.

I added a XCUI test for this page. I learned that there is no way to turn off network on iOS Simulator programatically, so in order to use this test, you should turn off network on your computer, where you run the project.

Also, I added a check for the internet connectity. If there is no internet connectivity – test runs. In order to implement it, I referenced this article.

CC: @oliviabrown9

@oliviabrown9

This comment has been minimized.

Copy link
Member

oliviabrown9 commented Feb 27, 2019

@farhanpatel does Firefox iOS have any UI tests that check how the app handles connectivity issues? I'm not sure that such a test would be helpful since it requires manually turning off connectivity on the physical device (and thus would never be run on BuddyBuild) based on the info in this PR. How has Firefox iOS handled it or do you have advice for how we could handle it here?

@farhanpatel

This comment has been minimized.

Copy link

farhanpatel commented Mar 7, 2019

Hey @oliviabrown9 , So sorry I saw this late. We don't have any tests that I know of that test no network connectivity. We have tests to test things like FxA being down or Pocket not returning trending stories. But these are usually done by stubbing the API. Blocking all internet traffic to simulate offline isn't something we've tried.

I wonder if you could use NSAppTransportSecurity in the info.plist to do this. You might need a different scheme just for these offline tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.