This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 260
Fixes #1169: Add a test for the no internet connection page #1644
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // | ||
| // NoInternetConnectionTest.swift | ||
| // XCUITest | ||
| // | ||
| // Created by Volodymyr Klymenko on 2019-02-01. | ||
| // Copyright © 2019 Mozilla. All rights reserved. | ||
| // | ||
|
|
||
| import XCTest | ||
| import SystemConfiguration | ||
|
|
||
| public class ReachabilityTest { | ||
| class func isConnectedToNetwork() -> Bool { | ||
| var zeroAddress = sockaddr_in() | ||
| zeroAddress.sin_len = UInt8(MemoryLayout.size(ofValue: zeroAddress)) | ||
| zeroAddress.sin_family = sa_family_t(AF_INET) | ||
|
|
||
| let defaultRouteReachability = withUnsafePointer(to: &zeroAddress) { | ||
| $0.withMemoryRebound(to: sockaddr.self, capacity: 1) {zeroSockAddress in | ||
| SCNetworkReachabilityCreateWithAddress(nil, zeroSockAddress) | ||
| } | ||
| } | ||
|
|
||
| var flags = SCNetworkReachabilityFlags() | ||
| if !SCNetworkReachabilityGetFlags(defaultRouteReachability!, &flags) { | ||
| return false | ||
| } | ||
| let isReachable = (flags.rawValue & UInt32(kSCNetworkFlagsReachable)) != 0 | ||
| let needsConnection = (flags.rawValue & UInt32(kSCNetworkFlagsConnectionRequired)) != 0 | ||
| return (isReachable && !needsConnection) | ||
| } | ||
| } | ||
|
|
||
| class NoInternetConnectionTest: BaseTestCase { | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
| dismissFirstRunUI() | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| app.terminate() | ||
| super.tearDown() | ||
| } | ||
|
|
||
| func testConnectivity() { | ||
| if !ReachabilityTest.isConnectedToNetwork() { | ||
| loadWebPage("mozilla.com") | ||
| let noInternetConnection = app.staticTexts["The Internet connection appears to be offline."] | ||
| XCTAssertEqual("The Internet connection appears to be offline.", noInternetConnection.label) | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if statement is never reached. The connection is always on and so the test always pass, in order to make this test checking when the device is offline we would need to force that status on the device for it and so be able to check what happens.