Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

MTE_1889 move app folders to focus #3917

Conversation

isabelrios
Copy link
Collaborator

No description provided.

@isabelrios
Copy link
Collaborator Author

isabelrios commented Nov 16, 2023

Hello @relud! one question for you... I get the Glean probe-scraper github action failing on this PR consistently. We are moving all files to a new folder, focus-ios, is there a path we should change somewhere in our repo or your repo so that it works?
I'm also renaming it, but I think that's fine as per your comment on firefox-ios
Thanks!

@isabelrios
Copy link
Collaborator Author

isabelrios commented Nov 17, 2023

There are still some changes needed before this can be ready for review:

  • update the release workflow with the new files path if needed

We will not land this until Moday 20th once the v121 branch has been created

@isabelrios isabelrios force-pushed the irios-mte1889-move-app-folders-to-focus branch from 4165f7e to 0b1a6b1 Compare November 17, 2023 11:41
@isabelrios isabelrios marked this pull request as ready for review November 20, 2023 09:38
@isabelrios
Copy link
Collaborator Author

v121 branch has been created, we can land this and monitor all the workflows and builds to create follow up fixes if needed.

@isabelrios
Copy link
Collaborator Author

@flodolo I'm landing this PR with yet another changes in the path to localization scripts. I tested that locally but just letting you know in case we need a follow up fix here or in the l10n repo.

@isabelrios isabelrios merged commit 04398d7 into mozilla-mobile:main Nov 21, 2023
4 of 6 checks passed
@flodolo
Copy link
Contributor

flodolo commented Nov 21, 2023

@flodolo I'm landing this PR with yet another changes in the path to localization scripts. I tested that locally but just letting you know in case we need a follow up fix here or in the l10n repo.

Yes, it will need a follow-up. This is not only moving the script, but also the position of the clone of the l10n repository.

To ensure local tests are reliable, make sure to remove any focusios-l10n folder you might have hanging around before running the scripts.

@isabelrios
Copy link
Collaborator Author

@flodolo I'm landing this PR with yet another changes in the path to localization scripts. I tested that locally but just letting you know in case we need a follow up fix here or in the l10n repo.

Yes, it will need a follow-up. This is not only moving the script, but also the position of the clone of the l10n repository.

To ensure local tests are reliable, make sure to remove any focusios-l10n folder you might have hanging around before running the scripts.

Thanks, yes, I was doing that. I will repeat all the tests and create a follow up with the changes needed here.

github-merge-queue bot pushed a commit to mozilla/experimenter that referenced this pull request Nov 22, 2023
…ing (#9805)

Because

- focus-ios had its nimbus.fml.yaml file move recently (see
mozilla-mobile/focus-ios#3917)

This commit

- updates our fetch logic to support multiple potential FML file
locations; and
- updates focus_ios.fml_path to support the old and new paths.

Fixes #9804
isabelrios added a commit to isabelrios/firefox-ios that referenced this pull request Feb 14, 2024
* Refactor MTE-1889 Move app files into folder

* move entitlement files

* added ci_scripts folder

* move all files into firefox-ios-app

* fixing content blocker script in checkout

* add new path to swiftlint temp

* comment xcodebuild without path to project

* change folders name to focus-ios and focus-ios-tests

* adding nimbus-fml script

* adding new path to release workflow
isabelrios added a commit to isabelrios/firefox-ios that referenced this pull request Feb 20, 2024
…ios#3917)

* Refactor MTE-1889 Move app files into folder

* move entitlement files

* added ci_scripts folder

* move all files into firefox-ios-app

* fixing content blocker script in checkout

* add new path to swiftlint temp

* comment xcodebuild without path to project

* change folders name to focus-ios and focus-ios-tests

* adding nimbus-fml script

* adding new path to release workflow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants