Remove device #55
Merged
Remove device #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate which gets triggered when the delete button on DeviceManagementCell is tapped When removeDeviceEvent is triggered, disable and grey out cell, remove the device from AccountManager
…e current device is always at the top and make the devices property private. Having the list sorted makes it easier to remove devices from the array based on the tableview index
…ice management screen Add isCurrentDevice property to check if it should be labelled as such on the device management screen Modify the equatable function so device is considered the same only if the public keys are the same
…ist is set since it's being set in the init it will always be sorted
Need to still disable tab bar if this is true
…r sees the flow from home to settings to devices Remove devices parameter when initializing DeviceManagementViewController and get it from DependencyManager singleton
… - need to do this only for specific error messages
…ack the deviceKey in the removeDeviceEvent Disable cell and button when event gets triggered
… is in the center, add custom view as the cell divider, add activityIndicatorView to animate in place of the remove button when a device is in the process of being removes
…agementCell instead
…ween the top and bottom shrinks instead of the button resizing
…hey have too many devices
…moved or is the current device
Modify function calls with updated signatures
… going back from the devices screen to the settings
…ice to get back data with an error Need to clean up the addDevice call still
…Void as the success associated value instead of data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.