Commits on Nov 8, 2019

1. Use RxSwift to create a removeDeviceEvent on DeviceDataSourceAndDeleg… …

   …ate which gets triggered when the delete button on DeviceManagementCell is tapped
   
   When removeDeviceEvent is triggered, disable and grey out cell, remove the device from AccountManager

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for e0156ce
   • Browse repository at this point

   Copy the full SHA

   e0156ce View commit details

   Browse the repository at this point in the history

2. Change DeviceManagementCell.xib to highlight when selected

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for fecccd7
   • Browse repository at this point

   Copy the full SHA

   fecccd7 View commit details

   Browse the repository at this point in the history

3. Add a sortedDevices property to handle sorting the devices list so th… …

   …e current device is always at the top and make the devices property private. Having the list sorted makes it easier to remove devices from the array based on the tableview index

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for cf8717f
   • Browse repository at this point

   Copy the full SHA

   cf8717f View commit details

   Browse the repository at this point in the history

4. Add property isBeingRemoved so device will show greyed out on the dev… …

   …ice management screen
   
   Add isCurrentDevice property to check if it should be labelled as such on the device management screen
   Modify the equatable function so device is considered the same only if the public keys are the same

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 6d55caa
   • Browse repository at this point

   Copy the full SHA

   6d55caa View commit details

   Browse the repository at this point in the history

5. rename sortedDevices to deviceList and only sort devices when deviceL… …

   …ist is set since it's being set in the init it will always be sorted

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for b8e0b48
   • Browse repository at this point

   Copy the full SHA

   b8e0b48 View commit details

   Browse the repository at this point in the history

6. Change app to use the sorted device list

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 050c68e
   • Browse repository at this point

   Copy the full SHA

   050c68e View commit details

   Browse the repository at this point in the history

7. Add the token in the httpHeaderParams when removing a device

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 507601e
   • Browse repository at this point

   Copy the full SHA

   507601e View commit details

   Browse the repository at this point in the history

8. Move properties together

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for d67a163
   • Browse repository at this point

   Copy the full SHA

   d67a163 View commit details

   Browse the repository at this point in the history

9. Add removeDevice call to AccountManaging and NetworkRequesting

   

   connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 518f02a
   • Browse repository at this point

   Copy the full SHA

   518f02a View commit details

   Browse the repository at this point in the history

10. Add removeDevice call to AccountManager

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for e4ff0f3
    • Browse repository at this point

    Copy the full SHA

    e4ff0f3 View commit details

    Browse the repository at this point in the history

11. Update the devices list from the server once new device has been added

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 93ef49d
    • Browse repository at this point

    Copy the full SHA

    93ef49d View commit details

    Browse the repository at this point in the history

12. Modify logout call to pass in token which is needed when removing the… …

    … device

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for a4ca937
    • Browse repository at this point

    Copy the full SHA

    a4ca937 View commit details

    Browse the repository at this point in the history

13. Add throttle to prevent extra removeDevice calls, format cell when it… …

    …'s selected

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 02c87d8
    • Browse repository at this point

    Copy the full SHA

    02c87d8 View commit details

    Browse the repository at this point in the history

14. Use devices that's on user, move the canAddDevice check on user

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 9b90a72
    • Browse repository at this point

    Copy the full SHA

    9b90a72 View commit details

    Browse the repository at this point in the history

15. add canAddDevice computed property from device to user

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 67bcb96
    • Browse repository at this point

    Copy the full SHA

    67bcb96 View commit details

    Browse the repository at this point in the history

16. Us maxDevices on user instead of hardcoded 5

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for b63951f
    • Browse repository at this point

    Copy the full SHA

    b63951f View commit details

    Browse the repository at this point in the history

17. get devices from DependencyFactory and remove passing it in the init

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 66df95b
    • Browse repository at this point

    Copy the full SHA

    66df95b View commit details

    Browse the repository at this point in the history

18. If user can't add device, navigate to the devices screen …

    Need to still disable tab bar if this is true

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 7b0611b
    • Browse repository at this point

    Copy the full SHA

    7b0611b View commit details

    Browse the repository at this point in the history

19. If user reached maxDevices, navigate to the devices screen so the use… …

    …r sees the flow from home to settings to devices
    
    Remove devices parameter when initializing DeviceManagementViewController and get it from DependencyManager singleton

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 88642fd
    • Browse repository at this point

    Copy the full SHA

    88642fd View commit details

    Browse the repository at this point in the history

20. Remove setting the token and currentDevice to nil when the calls fail… …

    … - need to do this only for specific error messages

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 1e5c0da
    • Browse repository at this point

    Copy the full SHA

    1e5c0da View commit details

    Browse the repository at this point in the history

21. Add mutating functions to User to handle modifying and removing from … …

    …the devices list

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 656a5f7
    • Browse repository at this point

    Copy the full SHA

    656a5f7 View commit details

    Browse the repository at this point in the history

22. Modify DeviceManagementCell and DeviceDataSourceAndDelegate to pass b… …

    …ack the deviceKey in the removeDeviceEvent
    
    Disable cell and button when event gets triggered

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 1bb8066
    • Browse repository at this point

    Copy the full SHA

    1bb8066 View commit details

    Browse the repository at this point in the history

23. Modify priority on constraints to fix autolayout error

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 4cf5032
    • Browse repository at this point

    Copy the full SHA

    4cf5032 View commit details

    Browse the repository at this point in the history

24. Change the property 'template-rendering-intent' on all the icon asset… …

    …s to 'template'

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 7d5b1ec
    • Browse repository at this point

    Copy the full SHA

    7d5b1ec View commit details

    Browse the repository at this point in the history

25. On DeviceManagementCell remove title on the removeButton so the image… …

    … is in the center, add custom view as the cell divider, add activityIndicatorView to animate in place of the remove button when a device is in the process of being removes

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for e1221bb
    • Browse repository at this point

    Copy the full SHA

    e1221bb View commit details

    Browse the repository at this point in the history

26. Remove the tableView separator and use a custom view on the DeviceMan… …

    …agementCell instead

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 56cfe60
    • Browse repository at this point

    Copy the full SHA

    56cfe60 View commit details

    Browse the repository at this point in the history

27. Lower the priority on the top and bottom constraints so the space bet… …

    …ween the top and bottom shrinks instead of the button resizing

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for e814a5e
    • Browse repository at this point

    Copy the full SHA

    e814a5e View commit details

    Browse the repository at this point in the history

28. Add logic to automatically move the user to the devices screen when t… …

    …hey have too many devices

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for d1ba5fd
    • Browse repository at this point

    Copy the full SHA

    d1ba5fd View commit details

    Browse the repository at this point in the history

29. Format the device cell based on whether or not the device is being re… …

    …moved or is the current device

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 5793b21
    • Browse repository at this point

    Copy the full SHA

    5793b21 View commit details

    Browse the repository at this point in the history

30. rename boolean canAddDevice to hasTooManyDevices on User …

    Modify function calls with updated signatures

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for f096987
    • Browse repository at this point

    Copy the full SHA

    f096987 View commit details

    Browse the repository at this point in the history

31. Add back button chevron to the navigation controller and add flow for… …

    … going back from the devices screen to the settings

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 896b352
    • Browse repository at this point

    Copy the full SHA

    896b352 View commit details

    Browse the repository at this point in the history

32. Add lines with removed spaces

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 7374667
    • Browse repository at this point

    Copy the full SHA

    7374667 View commit details

    Browse the repository at this point in the history

33. Prevent rebuilding in nib

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 546e78a
    • Browse repository at this point

    Copy the full SHA

    546e78a View commit details

    Browse the repository at this point in the history

34. Change removeDevice to make a urlRequest that doesn't return data on … …

    …success

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 80942c4
    • Browse repository at this point

    Copy the full SHA

    80942c4 View commit details

    Browse the repository at this point in the history

35. Modify addDevice to get data on success and failure

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 074754e
    • Browse repository at this point

    Copy the full SHA

    074754e View commit details

    Browse the repository at this point in the history

36. Rename fire functions so they have different completion handler names

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 8754909
    • Browse repository at this point

    Copy the full SHA

    8754909 View commit details

    Browse the repository at this point in the history

37. Remove print statement in verify, use the dataHandler call for addDev… …

    …ice to get back data with an error
    
    Need to clean up the addDevice call still

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 59aee2e
    • Browse repository at this point

    Copy the full SHA

    59aee2e View commit details

    Browse the repository at this point in the history

38. Update the NetworkRequesting protocol removeDevice signature to pass … …

    …Void as the success associated value instead of data

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 46c4148
    • Browse repository at this point

    Copy the full SHA

    46c4148 View commit details

    Browse the repository at this point in the history

39. Fix fire call for removeDevice and current device cell formatting

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for d90cf8c
    • Browse repository at this point

    Copy the full SHA

    d90cf8c View commit details

    Browse the repository at this point in the history

40. add commented out code for disabling tab bar when devices are at max

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 209e427
    • Browse repository at this point

    Copy the full SHA

    209e427 View commit details

    Browse the repository at this point in the history

41. move commented out code to separate function

    

    connected-rkingsmill authored and Corby Ziesman committed Nov 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 717a560
    • Browse repository at this point

    Copy the full SHA

    717a560 View commit details

    Browse the repository at this point in the history