Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-2387: Fix iOS status bar color on iOS 16 #9644

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

mcleinman
Copy link
Collaborator

Description

This ended up being a bug on iOS 16 only, so the fix only affects iOS 16 and below. Somehow the status bar type is getting reset to default, causing the issue here. I checked all the places our code resets it to default, and it didn't seem to be happening in any of those spots - so I made this fix.

Once our minimum iOS version is iOS 17, we can remove this code - and I've left notes in the code that remind us of this.

Reference

VPN-2387

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman merged commit 1c251db into main Jun 7, 2024
116 checks passed
@mcleinman mcleinman deleted the vpn-2387-ios-status-bar branch June 7, 2024 22:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants