Bug 1862794 - Use function calls instead of const val for version and channel fields in Gecko object

[gabrielluong]

Changes here are needed to mozilla-mobile/firefox-android#4346

[jcristau]

We probably need to handle both the const val and the fun case here, because the former will still be needed on release branches after main switches to fun.

[gabrielluong]

We probably need to handle both the const val and the fun case here, because the former will still be needed on release branches after main switches to fun.

@jcristau Since we are using a tagged version of relbot in our actions https://github.com/mozilla-mobile/firefox-android/blob/main/.github/workflows/ac-update-geckoview.yml#L32, this shouldn't affect the release branches since they will be using a lower relbot version that will still function. We may also potentially be uplifting the const val to fun changes to the release branches as well based on the discussion in https://mozilla.slack.com/archives/C016PEDKY90/p1698969027616489. This will mean we will bump the relbot version in all the branches when this change lands.

Let me know how we should proceed because I can still make your requested changes, but there are implications if we also uplift the changes to the release branches. Alternatively, maybe I should be reading this as just adding both:

new_content = content.replace(
    f'const val version = "{old_gv_version}"',
    f'const val version = "{new_gv_version}"',
)
new_content = new_content.replace(
    f'fun version() = "{old_gv_version}"',
    f'fun version() = "{new_gv_version}"',
)

[jcristau]

Adding both seems reasonable to me, and means we don't have to worry about when/whether the firefox-android side of this change gets uplifted to any/all release branches.