This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1862794 - Use function calls instead of const val for version and channel fields in Gecko object. #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalmeida
approved these changes
Nov 3, 2023
|
This pull request has conflicts when rebasing. Could you fix it @kycn? 🙏 |
titooan
approved these changes
Nov 3, 2023
github-actions
bot
added
approved
kycn
added
🛬 needs landing
|
This pull request has conflicts when rebasing. Could you fix it @kycn? 🙏 |
kycn
added
🛬 needs landing
gabrielluong
added
approved
|
We will need a parallel changes to https://github.com/mozilla-mobile/relbot/blob/master/src/util.py#L77 and https://github.com/mozilla-mobile/relbot/blob/master/src/util.py#L93. The best way to test this would be to use a local fork of firefox-android and replace the github workflow with your fork relbot changes and force the github action to run with an older version of GV in Gecko.kt. |
|
This pull request has conflicts when rebasing. Could you fix it @kycn? 🙏 |
|
This pull request has conflicts when rebasing. Could you fix it @kycn? 🙏 |
… channel fields in Gecko object. Gradle sometimes does not fetch the GeckoView version stated in Gecko.kt file. This may be due to the combination of Gradle's compile avoidence feature and our use of ComponentsDependencies object. As the changes for GeckoView versions occur in Gecko.kt file and there's no change in DependenciesPlugin.kt file, Gradle sometimes does not recognize the changes in Gecko.kt file while parsing gradle files for fetching the changed library versions. To overcome this problem and make sure Gecko.kt file is always evaluated/parsed while Gradle sync operation is executed, the version and channel are no longer const val (i.e. static) but rather a function call that will have to be executed everytime.
gabrielluong
approved these changes
Nov 16, 2023
kycn
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle sometimes does not fetch the GeckoView version stated in Gecko.kt file. This may be due to the combination of Gradle's compile avoidence feature and our use of ComponentsDependencies object. As the changes for GeckoView versions occur in Gecko.kt file and there's no change in DependenciesPlugin.kt file, Gradle sometimes does not recognize the changes in Gecko.kt file while parsing gradle files for fetching the changed library versions. To overcome this problem and make sure Gecko.kt file is always evaluated/parsed while Gradle sync operation is executed, the version and channel are no longer const val (i.e. static) but rather a function call that will have to be executed everytime.
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1862794