Bug 1896964 - Cleanup firefox-android repo references #1000
Conversation
| "allowed_actions": ["release"], | ||
| "github_token": "SOME_TOKEN", | ||
| "github_owner": "mozilla-mobile", | ||
| "github_repo_name": "firefox-android", | ||
| "github_repo_name": "reference-browser", |
There was a problem hiding this comment.
reference-browser does not actually use githubscript. I've replaced firefox-android with reference-browser in examples and tests just to provide the name of an active github repo; open to suggestions for a better approach!
There was a problem hiding this comment.
Should we remove the mobile bits entirely and use an example from xpi instead?
| "allowed_actions": ["release"], | ||
| "github_token": "SOME_TOKEN", | ||
| "github_owner": "mozilla-mobile", | ||
| "github_repo_name": "firefox-android", | ||
| "github_repo_name": "reference-browser", |
There was a problem hiding this comment.
Should we remove the mobile bits entirely and use an example from xpi instead?
| "fenix": MobileVersion, | ||
| "firefox-android": MobileVersion, | ||
| "focus-android": MobileVersion, | ||
| "placeholder-repo": MobileVersion, # not currently used |
There was a problem hiding this comment.
Any reason to not just remove the unused code?
There was a problem hiding this comment.
Sorry, I'm not sure I understand what you had in mind. I removed that placeholder-repo line - it didn't add value. Were you thinking of removing _VERSION_CLASS_PER_END_OF_SOURCE_REPO? I've left it thinking that it's generic and might be useful again.
Of course treescript/github is also entirely unused now, but I think that's useful in the foreseeable future. Removing that, or cleaning up the github tests further, seems to get a little complicated; I wouldn't mind leaving that for a follow-up.
There was a problem hiding this comment.
Thanks.
I think we'll want to remove the beetmover mobile pools and the githubscript mobile prod pool from https://github.com/mozilla-services/cloudops-infra/blob/master/projects/relengworker/Jenkinsfile and https://github.com/mozilla-services/cloudops-infra/blob/master/projects/relengworker/Jenkinsfile.dev before deploying this, to avoid failed deploys.
…/scriptworker-scripts into no-firefox-android
New mozilla-version and scriptworker releases add support for ESR128.
Calling `random.sample()` on a dict_keys object no longer works ``` FAILED tests/test_aio.py::test_LockfileFuture[True] - TypeError: Population must be a sequence. For dicts or sets, use sorted(d). FAILED tests/test_aio.py::test_LockfileFuture[False] - TypeError: Population must be a sequence. For dicts or sets, use sorted(d). ``` https://docs.python.org/3/whatsnew/3.11.html#porting-to-python-3-11
``` FAILED tests/test_utils.py::test_pipe_to_log - TypeError: Passing coroutines is forbidden, use tasks explicitly. ``` Per https://docs.python.org/3.11/library/asyncio-task.html#asyncio.wait: "Changed in version 3.11: Passing coroutine objects to wait() directly is forbidden."
Assumes dependencies are the same or close enough to those on 3.9, at least until we move everything from 3.9 to 3.11.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.4 → v0.4.5](astral-sh/ruff-pre-commit@v0.4.4...v0.4.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Initially I didn't bother splitting these out because I figured they both require the exact same permissions on the repo anyway. So if the dev app secret were compromised, you'd be just as hosed as if the prod app secret were compromised. However, it didn't occur to me that we might only install the `dev` app on staging repos and that we don't want a bug on treescript-dev to accidentally expose the `prod` app's private key. To this end, I created a `releng-treescript-dev` app. We should probably avoid installing this app on production repos, and instead only add it to `staging-*` repos. To help with this, I restricted the app to the `mozilla-releng` org.
This assumes dependencies are the same or close enough as on python 3.9.
…0.4.2 (mozilla-releng#1018) * pushflatpakscript: Run on python 3.11, update flat-manager-client to 0.4.2 * pushflatpakscript: more changes to switch to python 3.11 --------- Co-authored-by: Julien Cristau <jcristau@mozilla.com>
No major bumps today.
…ozilla-releng#1015) * feat(treescript): Add support for fetching head revision with github client Mostly a refactor of existing code. * feat(treescript): Allow git and hg configuration simultaneously * feat(treescript): Enable git for Firefox treescript * refactor(treescript): Only bump l10n in merge day action when an l10n_bump action is also present This moves the decision about bumping l10n up to a higher level, which simplifies adding support for bumpning via github in the next commit. * feat(treescript): Add support for fetching l10n revisions from github. Most of this is copy/paste to avoid touching any of the existing l10n bumping code. The most notable change is in build_revision_dict_github, which is vastly simplified compared to its hg compared part. In part this is because we only have one string repo to worry about, but also because @eemeli declared that we don't need to support pinning revisions anymore - so I didn't implement that here. After we cut over to the Github repo and know we aren't going back, we can rip out the hg support. Most of the rest of this is just wiring in calls to l10n_bump_github when appropriate. * force treestatus check off for testing * style: pre-commit.ci auto fixes [...] --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…/scriptworker-scripts into no-firefox-android
| "checks" | ||
| ], | ||
| "priority": "highest", | ||
| "priority": "lowest", |
There was a problem hiding this comment.
heheh this is a good idea :)
Remove all references to the firefox-android and staging-firefox-android repos.