Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pushflatpak: pass flatpak-repackage log url to flat-manager-client (bug 1859510) #861

Merged
merged 4 commits into from Nov 14, 2023
Merged

pushflatpak: pass flatpak-repackage log url to flat-manager-client (bug 1859510) #861

merged 4 commits into from Nov 14, 2023

Conversation

jcristau
Copy link
Contributor

No description provided.

@jcristau jcristau requested a review from a team October 30, 2023 15:20
@jcristau jcristau marked this pull request as ready for review October 30, 2023 15:20
ahal
ahal approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what the expectations are around this file? E.g, are they going to link to it in which case will it be a problem when it expires? Hopefully they download + host it themselves

@jcristau
Copy link
Contributor Author

jcristau commented Nov 3, 2023

Do we know what the expectations are around this file? E.g, are they going to link to it in which case will it be a problem when it expires? Hopefully they download + host it themselves

@barthalion can you speak to that?

@jcristau jcristau merged commit 32983fd into mozilla-releng:master Nov 14, 2023
5 checks passed
@jcristau jcristau deleted the flatpak-build-log branch November 14, 2023 13:03
@barthalion
Copy link

Do we know what the expectations are around this file? E.g, are they going to link to it in which case will it be a problem when it expires? Hopefully they download + host it themselves

Apologies for the late answer. It doesn't need to be permanent -- the idea is to give users the possibility to establish a "chain of trust", and probably won't be looked beyond the latest release. Even if someone complains about that, we have no formal policy about how long the build log URL is supposed to be up anyway so it's really your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahal ahal ahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcristau @barthalion @ahal