Support multiple scope prefixes in bitrisescript #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
bitrisescript_prefixes
branch
from
23839a0
to
73e1619
Compare
ahal
force-pushed
the
bitrisescript_prefixes
branch
4 times, most recently
from
429c88a
to
ccb60e7
Compare
It turns out that we need to use consistent scope prefixes as the other scriptworkers as Taskgraph configures a single prefix across all scriptworkers. This means that the repo name can appear in the prefix, which in turn means we'll need to support multiple valid prefixes per trust domain. This is how the other scriptworkers work, so it's a good change to make anyway.
This is actually very verbose and makes the Taskcluster logs very difficult to read, so only log it on error.
ahal
force-pushed
the
bitrisescript_prefixes
branch
from
ccb60e7
to
b173820
Compare
hneiva
approved these changes
Mar 28, 2024
| return [prefix if prefix.endswith(":") else "{}:".format(prefix) for prefix in prefixes] | ||
|
|
||
|
|
||
| def extract_common_scope_prefix(config: dict[str, Any], task: dict[str, Any]) -> str: |
There was a problem hiding this comment.
are these scope resolution functions generic enough to move to something like scriptworker_client.task?
There was a problem hiding this comment.
I think so, good call! I copy/pasted it from another script and it looks like a bunch of them have something very similar.. Should be a follow-up though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.