Migrate to circle2.0 #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
reviewed
Mar 12, 2018
| # create a version.json per https://github.com/mozilla-services/Dockerflow/blob/master/docs/version_object.md | ||
| printf '{"commit":"%s","version":"%s","source":"https://github.com/%s/%s","build":"%s"}\n' \ | ||
| "$CIRCLE_SHA1" \ | ||
| "$CIRCLE_TAG" \ |
There was a problem hiding this comment.
Have you tested a build for a tag? CIRCLE_TAG's a bit suspicious now: https://discuss.circleci.com/t/circle-tag-documentation-for-2-0-points-to-1-x-documentation/13298/2
There was a problem hiding this comment.
You're right to be skeptical. Last I tried, you need to use a workflow to build tags on CircleCI 2.0. Note the documentation here: https://github.com/mozilla-services/ci-testground/blob/master/.circleci/config.yml#L144-L182.
|
Seems the CircleCI integration with GH is broken for some reason. Will come back and try it tomorrow 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from circleci 1.0 to 2.0 config syntax