Update to use CircleCI 2.0 configuration #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milescrabill
approved these changes
Mar 14, 2018
.circleci/config.yml
Outdated
| docker login -u $DOCKER_USER -p $DOCKER_PASS | ||
| docker tag app:build ${DOCKERHUB_REPO}:latest | ||
| docker push ${DOCKERHUB_REPO}:latest | ||
| elif [ ! -z "$CIRCLE_TAG" ]; then |
There was a problem hiding this comment.
use ${curly} syntax for consistency
.circleci/config.yml
Outdated
| # required since Workflows do not have the same remote docker instance. | ||
| - run: | ||
| name: docker save app:build | ||
| command: mkdir -p /cache ; docker save -o /cache/docker.tar "app:build" |
There was a problem hiding this comment.
remove space before semicolon
pjenvey
reviewed
Mar 15, 2018
| jobs: | ||
| build: | ||
| docker: | ||
| - image: docker:18.02.0-ce |
There was a problem hiding this comment.
we should stick w/ the latest stable: 17.12.1-ce. 18.02.0 is an edge release and probably not great for the long term (I imagine when the 18 line goes stable it'll be on a later minor revision)
There was a problem hiding this comment.
I don't think it matters because this is meant to be just an example repo of how to do things. No matter what it'll eventually be out of date. :)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for PR #33.
Works in CircleCI 2.0 now :)
Tested that tagging triggers a deployment and it works