Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpi: Add failing test to skip mixed case manifest.mf files #173

Closed
wants to merge 3 commits into from
Closed

xpi: Add failing test to skip mixed case manifest.mf files #173

wants to merge 3 commits into from

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Nov 14, 2018

fixes: #122

This should fail ...

@g-k g-k force-pushed the xpi-skip-mixed-case-manifest-mf-122 branch from a05f996 to 53d9ddc Compare January 3, 2019 19:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1317

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 79.277%
Totals Coverage Status
Change from base Build 1312: 0.09%
Covered Lines: 2104
Relevant Lines: 2654
💛 - Coveralls

@jvehent
Copy link
Contributor

jvehent commented Feb 15, 2019

is this still a thing we need?

@g-k
Copy link
Contributor Author

g-k commented Feb 15, 2019

Not if we get XPIs from AMO or well-formatted XPIs from non-AMO clients.

@g-k g-k closed this Feb 15, 2019
@g-k g-k deleted the xpi-skip-mixed-case-manifest-mf-122 branch February 15, 2019 16:28
@g-k g-k mentioned this pull request Feb 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port metainf case insensitivity tests for xpi sign file
3 participants
@g-k @coveralls @jvehent