Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update architecture.rst #265

Merged
merged 3 commits into from Apr 5, 2019
Merged

Update architecture.rst #265

merged 3 commits into from Apr 5, 2019

Conversation

jvehent
Copy link
Contributor

@jvehent jvehent commented Apr 4, 2019

No description provided.

@jvehent jvehent self-assigned this Apr 4, 2019
@jvehent jvehent requested a review from g-k April 4, 2019 18:26
@coveralls
Copy link

coveralls commented Apr 4, 2019 •
edited

Pull Request Test Coverage Report for Build 2410

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.568%
Totals Coverage Status
Change from base Build 2406: 0.0%
Covered Lines: 2825
Relevant Lines: 3840
💛 - Coveralls

g-k
g-k previously approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ w/ nit

docs/architecture.rst Outdated
utilize HSMs but limits the exposure of key material to memory accesses
(configurations are encrypted on disk and decrypted in memory).
Autograph is operated can dump key material from memory. Signers that utilize
an HSM a protected against this attack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "a protected" -> "are protected against"

@g-k g-k self-requested a review April 5, 2019 13:30
g-k
g-k approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@jvehent jvehent merged commit e085c3d into master Apr 5, 2019
@g-k g-k deleted the jvehent-patch-1 branch September 24, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-k g-k g-k approved these changes

Assignees

@jvehent jvehent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jvehent @coveralls @g-k