Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth config doc update #400

Merged
merged 2 commits into from Nov 22, 2019
Merged

Auth config doc update #400

merged 2 commits into from Nov 22, 2019

Conversation

hwine
Copy link
Contributor

@hwine hwine commented Nov 8, 2019

Pictures help! You can view the rendered diagram on the branch

@hwine hwine requested review from g-k and jvehent November 8, 2019 21:32
g-k
g-k previously approved these changes Nov 12, 2019
View reviewed changes
@g-k
Copy link
Contributor

g-k commented Nov 12, 2019

Look good! @hwine can you rebase with signed commits?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3815

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.047%
Totals Coverage Status
Change from base Build 3757: 0.0%
Covered Lines: 3514
Relevant Lines: 4946
💛 - Coveralls

g-k
g-k approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ lgtm

@g-k g-k merged commit 01ba060 into master Nov 22, 2019
@g-k g-k deleted the auth_config_doc_update branch November 22, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-k g-k g-k approved these changes

@jvehent jvehent Awaiting requested review from jvehent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hwine @g-k @coveralls