New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor auth backend #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4232
💛 - Coveralls |
g-k
force-pushed
the
refactor-auth-backend
branch
from
November 15, 2019 18:41
3fd1af5
to
bd8a428
Compare
Closed
jvehent
previously approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. a few nits but nothing important.
avoid confusion with tools/autograph-monitor monitor files
s/fmt./errors./g
don't rely on signer index IDs which are an impl detail of the in memory backend
g-k
force-pushed
the
refactor-auth-backend
branch
from
March 16, 2020 21:24
e4d4496
to
9464082
Compare
jvehent
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+. The code looks much cleaner too, which is 👌
refs: #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring for #96
to an in-memory implementation of a swappable authbackend interface that hides the signerIndex implementation details and update callers accordingly
makeSignerIndex
from theautographer
and index as auths are addedgetSignerForUser(userID, signerID string) (signer.Signer, error)
method instead ofgetSignerID
(which depends on access to the autographer signers andsignerIndex
)r? @jvehent