Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change test addon to ublock origin and vendor it #603

Merged
merged 2 commits into from Feb 24, 2021
Merged

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Feb 22, 2021

Change:

  • Add a test XPI fixture to the built image and change it to be the default for make integration-test

Fixes existing CI jobs failing with:

Creating project_app_run ... 
Creating project_app_run ... done--2021-02-21 05:23:56--  https://addons.mozilla.org/firefox/downloads/file/935711/pomodoro_clock-1.1.1-an+fx-windows.xpi
Resolving addons.mozilla.org (addons.mozilla.org)... 52.41.196.34, 44.235.202.42, 34.223.236.119
Connecting to addons.mozilla.org (addons.mozilla.org)|52.41.196.34|:443... connected.
HTTP request sent, awaiting response... 404 Not Found

and removes the CI dependency on AMO being up and serving the test addon

@coveralls
Copy link

coveralls commented Feb 22, 2021

Pull Request Test Coverage Report for Build 5403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 73.897%

Totals Coverage Status
Change from base Build 5381: 0.06%
Covered Lines: 3499
Relevant Lines: 4735

💛 - Coveralls

@diox
Copy link

diox commented Feb 22, 2021

Hey @g-k, this probably started failing because we deleted duplicate files on add-ons in mozilla/addons-server#16464 - relatively few public add-ons were affected, but I suspect the one you were using was.

I think you should avoid hardcoding AMO URLs - there is no guarantee that a particular XPI will always be available, and no guarantee that the download URL will stay the same either (it's not part of our supported API and could in theory change at any time without prior notice - in fact we were discussing doing that earlier today!). Why don't you commit a test xpi in the autograph repos directly ?

@g-k
Copy link
Contributor Author

g-k commented Feb 22, 2021

Why don't you commit a test xpi in the autograph repos directly ?

Yeah, that's a good idea. I think we were originally trying to avoid copying test XPIs into the images and working around CircleCI's lack of volume mounts

@g-k g-k changed the title tools: change test addon url to ublock origin change test addon to ublock origin and vendor it Feb 24, 2021
@g-k g-k marked this pull request as ready for review February 24, 2021 16:06
@g-k g-k merged commit 203b3d5 into master Feb 24, 2021
@g-k g-k deleted the fix-ci-test-webext-url branch February 24, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants