This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Fix delete error reporting. resolves bugzilla:1215253 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checked over the delete code to ensure that proper states and errors are being returned. Added tests to better guard against changes. * Removed "all" flag for delete_message * check state where possible and without increasing read costs.
| @@ -408,16 +417,14 @@ def delete_message(self, uaid, channel_id, message_id, updateid=None): | |||
| channel_id, message_id)) | |||
| return True | |||
|
|
|||
| def delete_messages(self, uaid, chidmessageids, all=False): | |||
| def delete_messages(self, uaid, chidmessageids): | |||
| with self.table.batch_write() as batch: | |||
| for chidmessageid in chidmessageids: | |||
There was a problem hiding this comment.
filter(None, chidmessageids) will remove the need for the if check on 423.
|
r+, minor nit though it's not needed so I'm merging as is |
bbangert
added a commit
that referenced
this pull request
Dec 21, 2015
bug: Fix delete error reporting. resolves bugzilla:1215253
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked over the delete code to ensure that proper states and errors are
being returned. Added tests to better guard against changes.
@bbangert r?