-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GCP Geolocation for IP Headers #44
Comments
Oh that is rad. This and the mooted rate-limiting headers injected from elsewhere will simplify the application code a lot! We will need to think about l10n but that should be solvable. |
Note, should make mmdb an optional data source, and take the header value as preferred. |
It should be, but we should figure this out sooner rather than later, I wouldn't want to force our l10n team to translate city and town names world-wide, because from the description of
From the description, the city names will never contain locale specific characters, e.g., an |
I suspect that the level of granularity for location is probably the same as the MaxMind DB, so probably draws the line at incorporated cities. I also strongly suspect that the suggested course for getting localization is to use the Translate service, and probably some heavy server side caching. I'm guessing that the channel server should probably do the translation based on the UA provided |
@l-hedgehog raised concerns about using GCP specific headers for this functionality since Moz China's FxA stack will remain in AWS. |
@shane-tomlinson @l-hedgehog, damn good note. To be honest, I don't see these as being replacements, rather, a cascade of "best effort" type attempts. Since the GCP headers will probably be more "up-to-date" than the MaxMind db, I can see using those preferentially, then falling back to doing a MaxMind if GCP comes up empty for whatever reason. A bit more sensitive question might be determining how we actually localize a locality (e.g. Hong Kong, or disputed areas in the Kashmir). Granted, with some of those spots, not quite sure getting Firefox sync working right is the highest priority item... |
* Switch outbound headers to middleware * Pull cargo package version from Cargo.toml for dev deploy Review note: This is more about setting up pulling the GCP info from the header. Since GCP does not localize, a proper fix will need to be in more than just "EN-US", but how we address that has not yet been finalized. Issue #44 Closes #59
Added w/ #63 |
See https://cloud.google.com/load-balancing/docs/backend-service#user-defined-request-headers
The text was updated successfully, but these errors were encountered: