feat: Use GCP header for backup localization info #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch outbound headers to middleware * Pull cargo package version from Cargo.toml for dev deploy Review note: This is more about setting up pulling the GCP info from the header. Since GCP does not localize, a proper fix will need to be in more than just "EN-US", but how we address that has not yet been finalized. Issue #44 Closes #59
pjenvey
reviewed
Nov 20, 2018
channelserver/src/meta.rs
Outdated
| if let Ok(loc_str) = ghead.to_str() { | ||
| let mut bits = loc_str.split(',').collect::<Vec<&str>>(); | ||
| let mut bi = bits.iter(); | ||
| sender.region = bi.next().map(|s| String::from(*s)); |
There was a problem hiding this comment.
nit: I'd prefer s.to_owned() just to be consistent w/ every where else
There was a problem hiding this comment.
Heh, mostly because (*s).to_owned() didn't look a lot better.
channelserver/src/main.rs
Outdated
| /// Set the OpSec headers on all responses. | ||
| fn response(&self, req: &HttpRequest<S>, mut resp: HttpResponse) -> Result<Response, Error> { | ||
| resp.headers_mut().insert( | ||
| header::HeaderName::try_from("Content-Security-Policy").unwrap(), |
There was a problem hiding this comment.
What about actix_web::middleware::DefaultHeaders (it basically does this)?
if this middleware is necessary:
unfortunately this does require the HeaderValue::from_static I think but you don't need the extra bits for the keys:
Suggested change
| header::HeaderName::try_from("Content-Security-Policy").unwrap(), | |
| "Content-Security-Policy", |
There was a problem hiding this comment.
thanks! looks like i can pass in str for both values.
pjenvey
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review note:
This is more about setting up pulling the GCP info from the header.
Since GCP does not localize, a proper fix will need to be in more than
just "EN-US", but how we address that has not yet been finalized.
Issue #44
Closes #59