Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ChannelIds to base64url #47

Closed
jrconlin opened this issue Oct 26, 2018 · 2 comments
Closed

Convert ChannelIds to base64url #47

jrconlin opened this issue Oct 26, 2018 · 2 comments
Assignees
@jrconlin
Labels
pairing/channelserver waffle:active

Comments

@jrconlin
Copy link
Member

(Still need to know what encoding, URL safe or standard)
@jrconlin jrconlin self-assigned this Oct 26, 2018
@jrconlin
Copy link
Member Author

mozilla/fxa-content-server#6667

@rfk rfk changed the title Convert ChannelIds to base64 Convert ChannelIds to base64url Oct 26, 2018
@rfk
Copy link
Contributor

rfk commented Oct 26, 2018

urlsafe please :-)

jrconlin added a commit that referenced this issue Oct 31, 2018
@jrconlin
feat: Switch channelIDs to base64
c52d760 
Closes #47
@jrconlin jrconlin mentioned this issue Oct 31, 2018
Merged
jrconlin added a commit that referenced this issue Nov 2, 2018
@jrconlin
feat: Switch channelIDs to base64 (#48)
ff3b1ec 
* feat: Switch channelIDs to base64

* change channelID to random char string
* fix group add (again)
* reduce number of times metadata fetched
* remove ChannelType, ChannelId
* change channel id to "session_id" to be clear where it comes from
* convert `From<String>` trait to `from_str() -> Result`

Closes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
pairing/channelserver waffle:active
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfk @jrconlin