Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Update channel-server-client to use base64url encoded channel IDs #6667

Closed
shane-tomlinson opened this issue Oct 26, 2018 · 2 comments · Fixed by #6674
Closed

Update channel-server-client to use base64url encoded channel IDs #6667

shane-tomlinson opened this issue Oct 26, 2018 · 2 comments · Fixed by #6674
Assignees
@shane-tomlinson
Labels
pairing/web content
Milestone
FxA-156: Fenix P...

Comments

@shane-tomlinson
Copy link

shane-tomlinson commented Oct 26, 2018 •
edited

Ref mozilla/fxa#317
blocks #6617
@shane-tomlinson shane-tomlinson self-assigned this Oct 26, 2018
@jrconlin
Copy link

Stupid question, but URL safe encoding (presuming) or standard?

@jrconlin jrconlin mentioned this issue Oct 26, 2018
Closed
@rfk
Copy link
Contributor

rfk commented Oct 26, 2018

Definitely urlsafe; we tend to call this "base64url" throughout existing code.

shane-tomlinson pushed a commit that referenced this issue Oct 29, 2018
feat(pairing): Add the pair/failure endpoint, handle more error cases.
2658fa2 
fixes #6667
fixes #6668
shane-tomlinson pushed a commit that referenced this issue Oct 29, 2018
fix(pairing): Expect the channelId to be a base64url string.
c292281 
We expected it to be hex, but agreed to use base64url instead.

fixes #6667
@shane-tomlinson shane-tomlinson mentioned this issue Oct 29, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shane-tomlinson shane-tomlinson

Labels
pairing/web content
Projects
None yet
Milestone
FxA-156: Fenix Pairing flow
Development

Successfully merging a pull request may close this issue.

fix(pairing): Expect the channelId to be a base64url string. mozilla/fxa-content-server
3 participants
@rfk @jrconlin @shane-tomlinson