Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

rename "hello" to "project_name" #595

Closed
wants to merge 1 commit into from
Closed

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Nov 25, 2015

see https://github.com/mozilla-services/cliquet/blob/master/cliquet/views/hello.py#L14

it seems to be clearer to rename it to project_name

@Natim
Copy link
Contributor

Natim commented Nov 25, 2015

Or just name

@Natim Natim self-assigned this Nov 25, 2015
@tarekziade
Copy link
Contributor Author

name vs project_name: what is the goal of having this value ? I am not sure I understand its utility

@Natim
Copy link
Contributor

Natim commented Nov 25, 2015

That's the hello page, there are no goal except being friendly with the people that end-up to that page.
That's the same utility as the documentation link. That's why we called it hello in the first place.

This page is the service saying hello to the world.

@leplatrem
Copy link
Contributor

project_name would match the setting name indeed.

@Natim
Copy link
Contributor

Natim commented Nov 25, 2015

The rationale behind preferring name rather than project_name is that we are on the project resource, so we already know the context, we just want the project property name.

The same way that we would prefer project.nameover project.project_name
The same way we declared project.documentation over project.project_documentation
The same way that we would prefer article.title rather than article.article_title

@leplatrem
Copy link
Contributor

Implemented in #600

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants