This repository has been archived by the owner on Feb 15, 2020. It is now read-only.
Issue #147 Utilize all the network bandwith when pulling data from S3 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| nr := bufio.NewReader(rc) | ||
| n, err := nr.WriteTo(os.Stdout) | ||
| if err != nil && err != io.EOF { | ||
| fmt.Fprintf(os.Stderr, "Error in attempt %d writing %s at offset %d: %s\n", attempt, s3Key, lastGoodOffset, err) |
There was a problem hiding this comment.
The only time I have seen this fail is with a broken pipe... retry won't help so we should probably just exit.
There was a problem hiding this comment.
+1 on aborting on failed write. It's unlikely to happen from something recoverable.
There was a problem hiding this comment.
Now seeing other errors too "connection reset by peer" which we do want to retry
I will do some more testing and special case the broken pipe.
There was a problem hiding this comment.
on Write? We definitely want to retry the Read....
There was a problem hiding this comment.
Ok, if it can throw read or write errors, you should probably leave the retry :-/
mreid-moz
added a commit
that referenced
this pull request
Nov 23, 2015
Issue #147 Utilize all the network bandwith when pulling data from S3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.