Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AlertMeta more strictly defined #358

Closed
ajvb opened this issue Apr 6, 2020 · 1 comment
Closed

Make AlertMeta more strictly defined #358

ajvb opened this issue Apr 6, 2020 · 1 comment
Assignees
@ameihm0912
Labels
improvement

Comments

@ajvb
Copy link
Contributor

ajvb commented Apr 6, 2020

Make AlertMeta more strictly defined rather than the current free form key strings everywhere.

Currently there are free form ("magic strings") everywhere for metedata key names. This is also present throughout the cloud functions (https://github.com/mozilla-services/foxsec-pipeline/blob/master/contrib/bugzilla-alert-manager/manager.go#L121).

We should make these keys more strictly defined and do this in a way that can be tested and checked for both the Java and Go code.

Related to #182
@ajvb
Copy link
Contributor Author

ajvb commented Apr 7, 2020 

$ ag getMetadataValue foxsec-pipeline/src/ | wc -l
604

@ameihm0912 ameihm0912 self-assigned this Apr 9, 2020
ameihm0912 pushed a commit that referenced this issue Apr 15, 2020
remove string usage in metadata
c71d1d7 
Related to #358

This removes all usage of strings as metadata keys in Java code. This
does not yet cover off the relationship with cloud functions, which
would be the next step.

What also needs to happen following this is a larger consolidation of
key names as there are a lot of duplicates and potentially unused
values, and we can probably reduce the total key count.
@ameihm0912 ameihm0912 mentioned this issue Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ameihm0912 ameihm0912

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajvb @ameihm0912