remove string usage in metadata #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #358 This removes all usage of strings as metadata keys in Java code. This does not yet cover off the relationship with cloud functions, which would be the next step. What also needs to happen following this is a larger consolidation of key names as there are a lot of duplicates and potentially unused values, and we can probably reduce the total key count.
|
One additional note here, this PR also removes all the extra metadata being added in gatekeeper; this was largely not useful so we are eliminating it in favor of the using the source to get the details. |
kkleemola
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #358
This removes all usage of strings as metadata keys in Java code. This
does not yet cover off the relationship with cloud functions, which
would be the next step.
What also needs to happen following this is a larger consolidation of
key names as there are a lot of duplicates and potentially unused
values, and we can probably reduce the total key count.
PRing this now because this diff is starting to become a bit unwieldy but this represents the major portion of what is required for #358 and we can piece out the rest in other PRs.