Merge pull request #182 from mozilla-services/181

Use eslint for js validation #181

.eslintrc

@@ -0,0 +1,33 @@
+{
+    "rules": {
+        "indent": [
+            2,
+            2
+        ],
+        "quotes": [
+            2,
+            "double"
+        ],
+        "linebreak-style": [
+            2,
+            "unix"
+        ],
+        "semi": [
+            2,
+            "always"
+        ]
+    },
+    "env": {
+        "es6": true,
+        "node": true,
+        "browser": true
+    },
+    "extends": "eslint:recommended",
+    "ecmaFeatures": {
+        "jsx": true,
+        "experimentalObjectRestSpread": true
+    },
+    "plugins": [
+        "react"
+    ]
+}

leaderboard/static/js/cachedfetch.js

@@ -10,7 +10,7 @@ module.exports = {
         this.keys[key] = this.keys[key].then(function (data) {
           return preprocessor(data);
         });
-      };
+      }
     }
 
     return this.keys[key];

leaderboard/static/js/leaderboard.react.js

@@ -1,6 +1,8 @@
+/*global React ReactDOM*/
+
 var dispatcher = require("./dispatcher.js");
 var cachedFetch = require("./cachedfetch.js");
-var getUrlParameters = require('./parseurl.js').getUrlParameters;
+var getUrlParameters = require("./parseurl.js").getUrlParameters;
 var getLeadersKey = require("./leaderskey.js");
 
 var LeaderMap = require("./leadermap.react.js").LeaderMap;
@@ -64,7 +66,7 @@ var Leaderboard = React.createClass({
     for (var paramName in selection) {
       var paramValue = selection[paramName];
       if ((paramValue != null) && ((("" + paramValue).length) > 0)) {
-        newLocationParams.push(paramName + '=' + paramValue);
+        newLocationParams.push(paramName + "=" + paramValue);
       }
     }
 
@@ -145,4 +147,4 @@ module.exports = {
       document.getElementById("leaderboard-container")
     );
   }
-}
+};

leaderboard/static/js/leadermap.react.js

@@ -1,6 +1,8 @@
+/*global React L*/
+
 var dispatcher = require("./dispatcher.js");
 var cachedFetch = require("./cachedfetch.js");
-var promisescript = require('promisescript');
+var promisescript = require("promisescript");
 
 // Style constants
 var countryStyleEmpty = {
@@ -79,26 +81,26 @@ var LeaderMap = React.createClass({
 
         layer.setStyle(countryStyleFilled);
 
-        layer.on("mouseover", (e) => {
+        layer.on("mouseover", () => {
           layer.setStyle(countryStyleHover);
         });
 
-        layer.on("mouseout", (e) => {
+        layer.on("mouseout", () => {
           if (countryIso2 === this.props.selection.iso2) {
             layer.setStyle(countryStyleSelected);
           } else {
             layer.setStyle(countryStyleFilled);
           }
         });
 
-        layer.on("click", (e) => {
+        layer.on("click", () => {
           this.map.closePopup(this.popup);
 
           dispatcher.fire("updateSelection", {
             iso2: countryIso2
           });
         });
-      }
+      };
 
       L.geoJson(
         countriesGeo, {

leaderboard/static/js/leaderprofile.react.js

@@ -1,3 +1,5 @@
+/*global React*/
+
 var cachedFetch = require("./cachedfetch.js");
 var dispatcher = require("./dispatcher.js");
 
@@ -20,7 +22,7 @@ var LeaderCountryRow = React.createClass({
         <td><a href="" onClick={this.handleClick}>{countryName}</a></td>
         <td>{this.props.rank.observations}</td>
       </tr>
-    )
+    );
   }
 });
 
@@ -60,12 +62,12 @@ var LeaderProfile = React.createClass({
                   selection={this.props.selection}
                   rank={rank}
                 />
-              )
+              );
             })}
           </tbody>
         </table>
       </div>
-    )
+    );
   }
 });
 

leaderboard/static/js/leaderskey.js

@@ -1,3 +1,3 @@
 module.exports = function (selection) {
   return "countryLeaders:" + selection.iso2 + ":" + selection.offset;
-}
+};

leaderboard/static/js/leadertable.react.js

@@ -1,3 +1,5 @@
+/*global React*/
+
 var dispatcher = require("./dispatcher.js");
 var cachedFetch = require("./cachedfetch.js");
 var getUrlParameters = require("./parseurl.js").getUrlParameters;
@@ -20,14 +22,14 @@ var LeadersButton = React.createClass({
     return (
         <button onClick={this.handleClick} className={classes}>{this.props.name}</button>
     );
-  },
+  }
 });
 
 var LeadersHeader = React.createClass({
   getInitialState: function () {
     return {
-      countries: [],
-    }
+      countries: []
+    };
   },
 
   componentDidMount: function () {
@@ -54,13 +56,13 @@ var LeadersHeader = React.createClass({
                 <option key={countryIso2} value={countryIso2}>
                   {countries[countryIso2].name}
                 </option>
-              )
+              );
             })}
           </select>
         </div>
       </div>
     );
-  },
+  }
 });
 
 var LeadersFooter = React.createClass({
@@ -86,7 +88,7 @@ var LeadersFooter = React.createClass({
         </div>
       </div>
     );
-  },
+  }
 });
 
 var LeaderTableRow = React.createClass({
@@ -107,7 +109,7 @@ var LeaderTableRow = React.createClass({
         <td><a href="" onClick={this.handleClick}>{this.props.leader.name}</a></td>
         <td>{this.props.leader.observations}</td>
       </tr>
-    )
+    );
   }
 });
 
@@ -130,12 +132,12 @@ var LeaderTableRows = React.createClass({
                 selection={this.props.selection}
                 leader={leader}
               />
-            )
+            );
           })}
         </tbody>
       </table>
     );
-  },
+  }
 });
 
 var LeaderTable = React.createClass({
@@ -179,8 +181,8 @@ var LeaderTable = React.createClass({
   },
 
   render: function() {
-    var start = 0,
-        stop = 0;
+    var start = 0;
+    var stop = 0;
 
     if (this.state.leaders.length > 0) {
       start = this.state.leaders[0].rank;

leaderboard/static/js/parseurl.js

@@ -17,4 +17,4 @@ function getUrlParameters(url) {
 module.exports = {
   parseUrl: parseUrl,
   getUrlParameters: getUrlParameters
-}
+};