This repository has been archived by the owner on May 24, 2019. It is now read-only.
Improve performance of compute_ranks country matching #282 #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than compare distances to every country, attempt to find a country which contains the point and fail fast. Otherwise compute distances and find the nearest one.
I compared performance between doing this in memory and letting the database do it using st_contains, and the performance with the db was every so slightly worse than the in memory case, but only slightly. However, reducing load on the db is a good thing, so I think doing it in memory should be fine. This is roughly 4 times faster than simply sorting by all distances and doing no containment checks, according to my local benchmarking.