Skip to content
This repository has been archived by the owner on May 24, 2019. It is now read-only.

Further tweaks to compute_ranks. #285

Closed
wants to merge 2 commits into from
Closed

Further tweaks to compute_ranks. #285

wants to merge 2 commits into from

Conversation

hannosch
Copy link
Contributor

@hannosch hannosch commented May 3, 2016

@jaredkerim

I tried to add a couple more tweaks based on your PR, done in an extra commit:

  • The country query limits the fields, so it doesn't download additional fields like iso codes, or population estimates.
  • The countries are ordered by area in decreasing order instead of name. So largest areas/countries will be checked first, since those have a higher chance of containing the points.
  • I've added prepared geometries, which should be faster at contains queries but don't support distance.

I don't have a large enough sample dataset to try this, could you sanity check that this actually improves things?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 622e06c on hannosch:282-hannosch into 5fa2be8 on mozilla-services:master.

@jaredlockhart
Copy link
Collaborator

I'm creating another pull request for this to rebase it on top of master.

@hannosch hannosch deleted the 282-hannosch branch May 3, 2016 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants