Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace replace_into with alternative #19

Closed
pjenvey opened this issue Mar 26, 2018 · 0 comments
Closed

Replace replace_into with alternative #19

pjenvey opened this issue Mar 26, 2018 · 0 comments
Assignees
@pjenvey
Labels
enhancement New feature or request
Milestone
2018Q1-1.3 Design...

Comments

@pjenvey
Copy link
Member

pjenvey commented Mar 26, 2018

The mysql replace_into we're using is not ideal, it ends up executing a delete/insert. This doesn't preserve the original creation date field. We should switch to mysql's INSERT INTO/ON DUPLICATE KEY UPDATE or use a transaction to do something similar.

The 'new broadcast' call really seems like a PUT request, (since it's really a create or update on a broadcast resource), ideally we'd return a 201 created when appropriate..
@pjenvey pjenvey added the enhancement New feature or request label Mar 26, 2018
@pjenvey pjenvey self-assigned this Mar 26, 2018
pjenvey added a commit that referenced this issue Mar 29, 2018
@pjenvey
feat: switch REPLACE INTO -> INSERT ON DUPLICATE KEY UPDATE
bb29009 
diesel refuses to support the latter due to its many gotchas but for
our simple setup it's nicer than REPLACE INTO

also switch POST -> PUT and return 201 when newly created

Closes #19
pjenvey added a commit that referenced this issue Mar 30, 2018
@pjenvey
feat: switch REPLACE INTO -> INSERT ON DUPLICATE KEY UPDATE
fb2b658 
diesel refuses to support the latter due to its many gotchas but for
our simple setup it's nicer than REPLACE INTO

also switch POST -> PUT and return 201 when newly created

Closes #19
pjenvey added a commit that referenced this issue Mar 30, 2018
@pjenvey
feat: switch REPLACE INTO -> INSERT ON DUPLICATE KEY UPDATE
d19756b 
diesel refuses to support the latter due to its many gotchas but for
our simple setup it's nicer than REPLACE INTO

also switch POST -> PUT and return 201 when newly created

Closes #19
@pjenvey pjenvey mentioned this issue Mar 30, 2018
Merged
pjenvey added a commit that referenced this issue Mar 30, 2018
@pjenvey
feat: switch REPLACE INTO -> INSERT ON DUPLICATE KEY UPDATE
aead0ca 
diesel refuses to support the latter due to its many gotchas but for
our simple setup it's nicer than REPLACE INTO

also:

o switch POST -> PUT and return 201 when newly created
o force binding to all interfaces for deployment

Closes #19
pjenvey added a commit that referenced this issue Mar 30, 2018
@pjenvey
feat: switch REPLACE INTO -> INSERT ON DUPLICATE KEY UPDATE
f09af1c 
diesel refuses to support the latter due to its many gotchas but for
our simple setup it's nicer than REPLACE INTO

also:

o switch POST -> PUT and return 201 when newly created
o force binding to all interfaces for deployment

Closes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
enhancement New feature or request
Projects
None yet
Milestone
2018Q1-1.3 Design and initial work co...
Development

No branches or pull requests
2 participants
@pjenvey @jrconlin