Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v to installation ping #545

Merged
merged 2 commits into from
May 8, 2020

Conversation

fbertsch
Copy link
Contributor

@fbertsch fbertsch commented May 8, 2020

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • If the PR comes from a fork, trigger the integration CI test by pushing this revision as discussed in the README and review the report posted in the comments.

For glean changes:

  • Update include/glean/CHANGELOG.md

@fbertsch fbertsch requested a review from mreid-moz May 8, 2020 17:43
@auto-assign auto-assign bot requested a review from wlach May 8, 2020 17:44
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really understanding the underlying mechanisms here, but this looks fine in outline.

@fbertsch
Copy link
Contributor Author

fbertsch commented May 8, 2020

Thanks @wlach! Some discussion in the team slack channel. Basically the pipeline errors telemetry pings without v or version fields.

@fbertsch fbertsch merged commit 175795c into mozilla-services:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants