Make sure we can decrypt what we have encrypted before returning it to the user. #105
Conversation
| return JSON.stringify(data); | ||
| try { | ||
| var jsonCipher = JSON.stringify(data); | ||
| decrypt(hawkId, jsonCipher); |
There was a problem hiding this comment.
decrypt is not defined according to Travis
|
Updated. |
|
lgtm |
Make sure we can decrypt what we have encrypted before returning it to the user.
|
FYI, the errors were traced down to a node-sodium memory-management bug which caused corrupted messages once every few thousand operations. The proposed fix is in paixaop/node-sodium#20 , and resolves the problem in my local tests. The try-again-after-failure approach is also sound (it's possible, but unlikely, that it will fail multiple times in a row, and so that function might take a while to finish, but there's no exit path that will result in an undecryptable message). If it takes the node-sodium folks a while to get a new release out, you might want to look at other places where you're using those APIs and consider similar guards. |
|
Thank you @warner for the digging. |
No description provided.